Chore/clang tidy amdgpu#30
Merged
diptorupd merged 2 commits intoROCm:amd-integrationfrom May 8, 2026
Merged
Conversation
diptorupd
force-pushed
the
chore/clang-tidy-amdgpu
branch
from
8f654d9 to
0799144
Compare
Adds .github/workflows/clang_tidy_amdgpu.yml plus three scripts under
.github/workflows/scripts_new/clang_tidy_amdgpu/ that:
1. install clang-tidy-14 + the same apt deps as the upstream
clang_tidy workflow,
2. cmake-configure (no build) with QD_WITH_AMDGPU=ON and the other
backends OFF, generating build/compile_commands.json,
3. run clang-tidy only on quadrants/(codegen|platform|rhi|runtime)/
amdgpu/ in parallel.
To support (2), build.py grows a new `configure` action that reuses the
toolchain bootstrap (clang, prebuilt LLVM 22.1.0, sccache, OS pkgs) from
`action_wheel` but stops after `cmake -B build -G Ninja`.
The workflow only runs on PRs that touch AMDGPU sources, the workflow
itself, or .clang-tidy. The upstream clang_tidy.yml is left untouched
and will be disabled on this fork via repo settings; an upstream PR
proposing the same changes will follow separately.
diptorupd
force-pushed
the
chore/clang-tidy-amdgpu
branch
from
0799144 to
a8dffcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds .github/workflows/clang_tidy_amdgpu.yml plus three scripts under
.github/workflows/scripts_new/clang_tidy_amdgpu/ that:
clang_tidy workflow,
backends OFF, generating build/compile_commands.json,
amdgpu/ in parallel.
To support (2), build.py grows a new
configureaction that reuses thetoolchain bootstrap (clang, prebuilt LLVM 22.1.0, sccache, OS pkgs) from
action_wheelbut stops aftercmake -B build -G Ninja.The workflow only runs on PRs that touch AMDGPU sources, the workflow
itself, or .clang-tidy. The upstream clang_tidy.yml is left untouched
and will be disabled on this fork via repo settings; an upstream PR
proposing the same changes will follow separately.