Add hip-python to MITuna venv#2332
Merged
justinrosner merged 7 commits intodevelopfrom Apr 7, 2026
Merged
Conversation
umangyadav
approved these changes
Apr 6, 2026
Mr-Anyone
approved these changes
Apr 6, 2026
Contributor
Mr-Anyone
left a comment
Mr-Anyone
left a comment
There was a problem hiding this comment.
I have a two approved PR, and it would be nice if I could merged them after this lands.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to unblock PR CI jobs by ensuring the MITuna execution environment has hip-python available, even when running on older images/venvs that don’t include it.
Changes:
- Add a runtime
pip installstep forhip-pythonbefore invokingtuna_run. - Extend
PYTHONPATHso the newly installed package is importable during the tuning run.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dorde-antic
approved these changes
Apr 7, 2026
umangyadav
pushed a commit
that referenced
this pull request
Apr 9, 2026
* Add hip-python to MITuna venv * Fix tuna script * Log errors * More venv tests * More test changes * Remove Dockerfile changes * Attend to Copilot comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a issue that is impacting PR CI jobs. E.g., https://ml-ci-internal.amd.com/job/MLIR/job/mlir/job/PR-2307/14/pipeline-overview/?selected-node=793
Technical Details
This fix updates tuna-script.sh to install
hip-pythonfor the MITuna venv. We currently have to install it to the tmp directory as the CI job doesn't have permissions otherwise. Note, this is only temporary until #2310 is merged in.Test Plan
Test Result
Submission Checklist