[AIROCMLIR-707] Make attentionSweeps split_kv filter device-memory-aware#2366
Draft
bogdan-petkovic wants to merge 1 commit intoROCm:developfrom
Draft
Conversation
Signed-off-by: bogdan-petkovic <bogdan.petkovic@htecgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some attention sweep samples with large split_kv generate very high temporary storage pressure and are currently rejected as FAIL after entering the pipeline.
This PR adds an early sweep-side prefilter so memory-heavy splitKV cases can be skipped before expensive execution, reducing wasted sweep effort while keeping existing compiler/runtime behavior unchanged.
Technical Details
Updated mlir/utils/performance/attentionSweeps.py to add a device-memory-aware splitKV prefilter in sampling:
Refactored sample filtering to track reasons separately:
Added focused unit tests in mlir/utils/performance/tests/test_attentionSweeps.py:
No compiler/verifier logic was changed in this PR; scope is limited to sweep generation/filtering behavior.
Test Plan
Test Result
Submission Checklist