Skip to content

Add .devcontainer Docker for users#5

Open
jamesETsmith wants to merge 8 commits intoamd-integrationfrom
feature/rocm_docker_config
Open

Add .devcontainer Docker for users#5
jamesETsmith wants to merge 8 commits intoamd-integrationfrom
feature/rocm_docker_config

Conversation

@jamesETsmith
Copy link
Copy Markdown
Collaborator

Summary

This PR makes the following changes to Dockerfile.theRock_ci:

  • Splits up the installation of dependencies from the build of warp. This speeds up dev workflows
  • Moves the copy of the source files until after the dependencies are installed so that builds are faster when making source file changes
  • makes the theRock version configurable (it was hardcoded before)
  • installs rocprofiler-compute (currently hardcoded)

Before your PR is "Ready for review"

  • All commits are signed-off to indicate that your contribution adheres to the Developer Certificate of Origin requirements
  • Necessary tests have been added
  • Documentation is up-to-date
  • Auto-generated files modified by compiling Warp and building the documentation have been updated (e.g. __init__.pyi, docs/api_reference/, docs/language_reference/)
  • Code passes formatting and linting checks with pre-commit run -a

…pip and address some of the issues with the build system that expected things in /opt/rocm
…tages for installing prereqs and building warp to speed up iterative development on the image
@jamesETsmith jamesETsmith requested a review from rtmadduri March 25, 2026 20:09
@jamesETsmith jamesETsmith self-assigned this Mar 25, 2026
@jamesETsmith jamesETsmith added the enhancement New feature or request label Mar 25, 2026
@jamesETsmith
Copy link
Copy Markdown
Collaborator Author

jamesETsmith commented Mar 26, 2026

@rtmadduri I'm seeing now that the installation of torch overrides the version of the rock we've specified. We need to tie those two installations together. It may require us to use the whole ugly path for torch, e.g. torch-2.9.1+rocm7.13.0a20260314-cp310-cp310-linux_x86_64.whl

A warning about this is buried in the rock docs here

@rtmadduri
Copy link
Copy Markdown
Collaborator

@jamesETsmith, I think these are good changes and I have been thinking about it and I realize we should probably have 2 different Dockerfiles. This one was designed for CI and we should keep it as lightweight as possible and installing only those dependencies that are absolutely necessary for unit tests to run. (So we probably dont need rocprof in the CI container)

I think we should keep the versioning changes and the parameterization of the ROCk URL and revert the rest. Those changes can go into a separate Dockerfile as part of the .devcontainer directory (Following standard conventions)

@rtmadduri rtmadduri changed the title Feature/rocm docker config Add .devcontainer Docker for users Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants