Fix packaging for current Discord tarballs#34
Open
vsego wants to merge 2 commits into
Open
Conversation
Discord's download endpoint and Linux tarball layout changed enough to break the old build script: downloads could silently fail, stable now uses the lowercase discord launcher, and the package no longer contains top-level .so files. Harden the download/extract path and update the spec install step for the current archive layout.
Declare root:root as the default owner and group for packaged files so installs do not depend on build environment ownership.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord's Linux tarball layout changed and the existing packaging script no longer builds a usable RPM. The download path could also fail silently, leaving an empty package version and a later rpmbuild failure.
This updates the download endpoint, makes download/extract/build failures fatal, handles the lowercase stable launcher name, and updates the spec install step for the current archive layout. It also makes packaged file ownership explicit with
%defattr(-,root,root,-).Tested with
./create-package.sh stable, building and installingdiscord-1.0.140-2.fc43.x86_64.rpm, then launching Discord successfully.