Conversation
…-IshSession and adapted all BeginProcessing in all cmdlets to fall back from local: to global:
There was a problem hiding this comment.
Pull request overview
This PR implements a fallback mechanism for session state retrieval by adding support for global-scoped ISHRemoteSessionStateIshSession variables. When cmdlets cannot find a session in the local scope, they now fall back to checking the global scope.
Changes:
- Added global scope fallback for IshSession retrieval across all cmdlets
- Updated New-IshSession to store session in both local and global scopes
- Added test coverage for both local and global session state storage
Reviewed changes
Copilot reviewed 85 out of 85 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| TrisoftCmdlet.cs | Defines new global session constant and updates documentation |
| NewIshSession.cs | Stores IshSession in both local and global scope variables |
| NewIshSession.Tests.ps1 | Adds tests verifying both local and global session storage |
| GetIshTypeFieldDefinition.cs | Adds global scope fallback in ProcessRecord method |
| GetIshTypeFieldDefinition.Tests.ps1 | Updates test to handle both local and global session state |
| Multiple cmdlet files | Adds global scope fallback and updates debug messages in BeginProcessing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Source/ISHRemote/Trisoft.ISHRemote/Cmdlets/Settings/GetIshTypeFieldDefinition.cs
Show resolved
Hide resolved
Source/ISHRemote/Trisoft.ISHRemote/Cmdlets/Settings/GetIshTypeFieldDefinition.Tests.ps1
Show resolved
Hide resolved
Source/ISHRemote/Trisoft.ISHRemote/Cmdlets/Settings/GetIshTypeFieldDefinition.Tests.ps1
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-IshSession and adapted all BeginProcessing in all cmdlets to fall back from local: to global: