Merged
Conversation
…H30Client, changed 3 enums and Id property to LogicalId to compile but got several errors. Refreshed OpenAPIAM10Client, no code changes but all OperationIds changed.... Probably not many scripts use OpenAPI proxies so could be resolved with breaking change documentation.
…M10Client, no code changes but all OperationIds changed.... Probably not many scripts use OpenAPI proxies so could be resolved with breaking change documentation.
…M10Client, no code changes but all OperationIds changed.... Probably not many scripts use OpenAPI proxies so could be resolved with breaking change documentation.
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenAPI proxy clients to align with newer API versions, specifically updating the Access Management API to version 20251210 and incorporating changes to OpenAPI ISH30 enumeration mappings.
Changes:
- Updated OpenAPI enumeration mappings for event-related levels (
EventProgressandEventProgressDetail) - Changed document object field from
IdtoLogicalIdinSetDocumentObject - Renamed all OpenAPI AM10 operation IDs to use snake_case format (e.g.,
IdentityProvidersGetAsync→IdentityProviders_GetAsync) - Updated test coverage to verify both legacy and new operation ID naming conventions
- Reorganized OpenAPI response definitions and updated example dates to 2025
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| OpenApiISH30EnumerationsExtensions.cs | Maps new event-related enum values (EventProgress, EventProgressDetail) to internal Level enumerations |
| IshFieldsExtensions.cs | Updates enum conversion and changes SetDocumentObject to use LogicalId instead of Id |
| NewIshSession.Tests.ps1 | Adds comprehensive test coverage for OpenAPI client operation IDs, including version-specific method lists and validation of new snake_case naming |
| OpenApiAM10.json | Updates API version to 20251210, renames all operationIds to snake_case format, reorders HTTP response codes, and updates example dates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.