fix: Update localizations for consistency by dandwyer · Pull Request #287 · RaidTheory/arcraiders-data

dandwyer · 2026-04-14T19:46:12Z

build: Add GitHub Actions workflow and Dependabot configuration
test: Add localized text type and associated tests
fix: Make changes to eliminate xfail for localized text validation tests

dandwyer · 2026-04-14T19:48:41Z

Here are workflow test results for each of the 3 loosely related commits in this PR:

baschny · 2026-04-14T20:07:36Z

@dandwyer I suggest that you split this PR in multiple ones by topic:

the data fixes (maybe even split these up in the "ko-KR" fixes and map-events)
then separate your new feature suggestion(s). Maybe split those also, as you are proposing a github actions workflow (which might be also discussable) and then the whole "zod" schema tests etc, which I personally find way to complicated for our simple use-case here.

Because: as a single pull request it is an "all or nothing" thing: if the maintainer disagrees with some tiny thing, the whole changes are stalled, even thou some of these are basically no-brainers.

dandwyer · 2026-04-14T20:33:07Z

Thanks for the feedback. I will firstly revise this PR to address 1. Then, I can follow up with 2, which was meant to be architectural enforcement to prevent inconsistency. As an example, 1 is largely rework related to another good faith attempt to make same updates, but some got missed and/or reversions got introduced later due to lack of architectural enforcement.

dandwyer · 2026-04-14T20:59:40Z

Only changed as a result of running bun run format so that bun run check would pass.

Removed this from scope of PR in latest push since it is not strictly required and in scope of adjacent #290 .

dandwyer · 2026-04-14T21:01:09Z

Changed name to match ko-KR convention established by: #249

dandwyer · 2026-04-14T21:01:50Z

+        "en": "Hurricane",
+        "de": "Hurrikan",
+        "fr": "Ouragan",
+        "es": "Huracán",
+        "pt": "Furacão",
+        "pt-BR": "Furacão",
+        "pl": "Huragan",
+        "no": "Orkan",
+        "da": "Orkan",
+        "it": "Uragano",
+        "ja": "ハリケーン",
+        "ko-KR": "허리케인",
+        "zh-CN": "飓风",
+        "zh-TW": "颶風",
+        "ru": "Ураган",
+        "tr": "Kasırga",
+        "uk": "Ураган",
+        "hr": "Uragan",
+        "sr": "Uragan",
+        "he": "הוריקן"


These translations are care of ChatGPT.

dandwyer · 2026-04-14T21:02:10Z

      "en": "Dam Battlegrounds",
      "es": "presas_campos_de_batalla",
      "fr": "Champ de Bataille du Barrage",
+      "he": "שדות הקרב של הסכר",


he translations are care of ChatGPT.

dandwyer · 2026-04-14T21:03:18Z

@baschny : Changes are now limited in scope to data fixes per your request.

baschny · 2026-04-15T08:53:33Z

@baschny : Changes are now limited in scope to data fixes per your request.

Very cool! I was not "requesting" it, it was just a suggestion - as I am not the maintainer of this (its @mattmarcin) - I am just a contributor.

Nevertheless the split up pull requests made it much easier to understand and merge individually.

The "ui" file might require some work from Matt still on arctracker.io, I think this is the reason why it was not changed yet.

dandwyer · 2026-04-15T14:51:48Z

@baschny : Changes are now limited in scope to data fixes per your request.

...
The "ui" file might require some work from Matt still on arctracker.io, I think this is the reason why it was not changed yet.

@baschny: Thank you for your comprehensive review.

@mattmarcin: I can remove the arctracker-ui/ko.json to arctracker-ui/ko-KR.json rename and provide it in a separate PR if that has frictions for inclusion in this PR. Please let me know.

pr: RaidTheory#287

dandwyer · 2026-04-22T20:19:39Z

Last force push was to rebase to main/latest and address conflicting merge in maps-event.json introduced by merge of #273.

pr: RaidTheory#287

dandwyer force-pushed the dandwyer branch from c794f10 to 5132368 Compare April 14, 2026 20:58

dandwyer changed the title ~~Add github workflows, localization tests, and localization enhancements~~ fix: Update localizations for consistency Apr 14, 2026

dandwyer commented Apr 14, 2026

View reviewed changes

Comment thread arctracker-ui/ko-KR.json

Copy link
Copy Markdown

Author

dandwyer Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed name to match ko-KR convention established by: #249

dandwyer commented Apr 14, 2026

View reviewed changes

This was referenced Apr 14, 2026

build: Add GitHub Actions workflow and Dependabot configuration #290

Open

test: Add localized text type and associated tests #291

Open

dandwyer force-pushed the dandwyer branch from 5132368 to aaea523 Compare April 14, 2026 21:39

dandwyer mentioned this pull request Apr 15, 2026

fix: Sanitize item JSON files for consistency #292

Open

dandwyer added a commit to dandwyer/arcraiders-data that referenced this pull request Apr 15, 2026

fix: Update localizations for consistency

b95ae64

pr: RaidTheory#287

dandwyer added a commit to dandwyer/arcraiders-data that referenced this pull request Apr 15, 2026

fix: Update localizations for consistency

bedfd8d

pr: RaidTheory#287

github-actions Bot pushed a commit to dandwyer/arcraiders-data that referenced this pull request Apr 15, 2026

fix: Update localizations for consistency

6f26804

pr: RaidTheory#287

dandwyer added a commit to dandwyer/arcraiders-data that referenced this pull request Apr 15, 2026

fix: Update localizations for consistency

a98c14b

pr: RaidTheory#287

github-actions Bot pushed a commit to dandwyer/arcraiders-data that referenced this pull request Apr 15, 2026

fix: Update localizations for consistency

cbc2364

pr: RaidTheory#287

dandwyer added a commit to dandwyer/arcraiders-data that referenced this pull request Apr 15, 2026

fix: Update localizations for consistency

0a9904e

pr: RaidTheory#287

dandwyer added a commit to dandwyer/arcraiders-data that referenced this pull request Apr 15, 2026

fix: Update localizations for consistency

f4fd34a

pr: RaidTheory#287

github-actions Bot pushed a commit to dandwyer/arcraiders-data that referenced this pull request Apr 16, 2026

fix: Update localizations for consistency

555eb99

pr: RaidTheory#287

dandwyer added a commit to dandwyer/arcraiders-data that referenced this pull request Apr 22, 2026

fix: Update localizations for consistency

f613717

pr: RaidTheory#287

dandwyer added a commit to dandwyer/arcraiders-data that referenced this pull request Apr 22, 2026

fix: Update localizations for consistency

074e7f9

pr: RaidTheory#287

fix: Update localizations for consistency

630f798

pr: RaidTheory#287

dandwyer force-pushed the dandwyer branch from aaea523 to 630f798 Compare April 22, 2026 20:16

github-actions Bot pushed a commit to dandwyer/arcraiders-data that referenced this pull request Apr 28, 2026

fix: Update localizations for consistency

9895712

pr: RaidTheory#287

github-actions Bot pushed a commit to dandwyer/arcraiders-data that referenced this pull request Apr 29, 2026

fix: Update localizations for consistency

475e349

pr: RaidTheory#287

github-actions Bot pushed a commit to dandwyer/arcraiders-data that referenced this pull request May 1, 2026

fix: Update localizations for consistency

76c9d68

pr: RaidTheory#287

github-actions Bot pushed a commit to dandwyer/arcraiders-data that referenced this pull request May 4, 2026

fix: Update localizations for consistency

719b64d

pr: RaidTheory#287

github-actions Bot pushed a commit to dandwyer/arcraiders-data that referenced this pull request May 7, 2026

fix: Update localizations for consistency

cbda2df

pr: RaidTheory#287

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Update localizations for consistency#287

fix: Update localizations for consistency#287
dandwyer wants to merge 1 commit intoRaidTheory:mainfrom
dandwyer:dandwyer

dandwyer commented Apr 14, 2026

Uh oh!

dandwyer commented Apr 14, 2026 •

edited

Loading

Uh oh!

baschny commented Apr 14, 2026

Uh oh!

dandwyer commented Apr 14, 2026

Uh oh!

dandwyer Apr 14, 2026

Uh oh!

dandwyer Apr 14, 2026

Uh oh!

dandwyer Apr 14, 2026

Uh oh!

dandwyer Apr 14, 2026

Uh oh!

dandwyer Apr 14, 2026

Uh oh!

dandwyer commented Apr 14, 2026

Uh oh!

baschny commented Apr 15, 2026

Uh oh!

dandwyer commented Apr 15, 2026

Uh oh!

dandwyer commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dandwyer commented Apr 14, 2026

Uh oh!

dandwyer commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baschny commented Apr 14, 2026

Uh oh!

dandwyer commented Apr 14, 2026

Uh oh!

dandwyer Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

dandwyer Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

dandwyer Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

dandwyer Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

dandwyer Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

dandwyer commented Apr 14, 2026

Uh oh!

baschny commented Apr 15, 2026

Uh oh!

dandwyer commented Apr 15, 2026

Uh oh!

dandwyer commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dandwyer commented Apr 14, 2026 •

edited

Loading