Ensure peer_traverser does not unnecessarily expand the graph#477
Merged
Ralith merged 1 commit intoRalith:masterfrom Jan 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although I thought I caught this bug in #454 (comment), it was still present in the final version of the PR I merged.
The bug: When finding all parent nodes of the base node, I accidentally expand the graph in all directions from the base node when looking for descenders (by calling ensure_neighbor instead of neighbor and then comparing the "length" of the two nodes). This results in the graph having several times more nodes than it needs to have.
I've added a test case to ensure this bug does not show up again, in addition to simplifying the logic somewhat to make it easier to follow.