Skip to content

WrapperExe: don't set global LEGENDARY_WRAPPER_EXE after downloading an update #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loathingKernel merged 1 commit into from
Apr 26, 2026
+1 −2
Merged

WrapperExe: don't set global LEGENDARY_WRAPPER_EXE after downloading an update #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rare/models/wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def __eq__(self, other) -> bool:
return self.as_str == other.as_str

def __hash__(self):
return hash(self.__command)
return hash(" ".join(self.__command))

def __bool__(self) -> bool:
return True if not self.is_editable else bool(self.as_str.strip())
Expand Down
1 change: 0 additions & 1 deletion rare/utils/wrapper_exe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def download_lgd_wrapper() -> bool:
try:
resp = requests.get(download_url, timeout=5)
wrapper_path().write_bytes(resp.content)
config.set_envvar('default', 'LEGENDARY_WRAPPER_EXE', str(wrapper_path))
except requests.exceptions.Timeout:
return False

Expand Down
Loading