Skip to content

Ensure nChains is greater than 1 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhroom merged 2 commits into from
Mar 24, 2025
Merged

Ensure nChains is greater than 1 #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a111fa9
Change nChains to be greater than 1
alexhroom Mar 24, 2025
1f56de3
fixed tests
alexhroom Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RATapi/controls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class Controls(BaseModel, validate_assignment=True, extra="forbid", use_attribut
nSamples: int = Field(20000, ge=0)
"""[DREAM] The number of samples in the initial population for each chain."""

nChains: int = Field(10, gt=0)
nChains: int = Field(10, gt=1)
"""[DREAM] The number of Markov chains to use in the algorithm."""

jumpProbability: float = Field(0.5, gt=0.0, lt=1.0)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_controls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@ def test_dream_nSamples_error(self, value: int) -> None:
@pytest.mark.parametrize("value", [-5, 0])
def test_dream_nChains_error(self, value: int) -> None:
"""Tests the nChains setter error in Dream class."""
with pytest.raises(pydantic.ValidationError, match="Input should be greater than 0"):
with pytest.raises(pydantic.ValidationError, match="Input should be greater than 1"):
self.dream.nChains = value

def test_control_class_dream_str(self, table_str) -> None:
Expand Down