Make query by family name case insensitive#88
Open
simartin wants to merge 1 commit into
Open
Conversation
While investigating a SVG text display issue in servo/resvg, I noticed that query does a case-sensitive matching on family name, while it should not according to my read of: https://www.w3.org/TR/2018/REC-css-fonts-3-20180920/#font-family-casing My initial problem was unrelated in the end, but I figured it'd still make sense to fix this discrepancy in fontdb (that sounds like a better place to fix than resvg, which is what I'm ultimately interested in). Signed-off-by: Simon Martin <simon@nasilyan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating a SVG text display issue in servo/resvg, I noticed that query does a case-sensitive matching on family name, while it should not according to my read of:
https://www.w3.org/TR/2018/REC-css-fonts-3-20180920/#font-family-casing
My initial problem was unrelated in the end, but I figured it'd still make sense to fix this discrepancy in fontdb (that sounds like a better place to fix than resvg, which is what I'm ultimately interested in).