Conversation
Owner
Author
|
Iframe players can be implemented directly with flutter_webview lib, if youtube_explode will explode at some point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This thing is so bad that i needed to use random fork to make it play something (official demo is also broken rn). But it kinda works in this branch atm.
I drawed seamless iframe player in my fantasies, but its pretty complicated to get yt player state / seek video / get aspect ratio, well, just like in original youtube iframe api.
I'm still not sure if this is better than currect
youtube_explode_dartway, because i'm not sure thatyoutube_explodewill load most videos without deno/node dependency. This splitting still can be useful at some moment, if i will want more player backends. Will try media_kit now.