Add fallback extractor support for SquashFS extraction#936
Open
pwnpope wants to merge 1 commit intoReFirmLabs:masterfrom
Open
Add fallback extractor support for SquashFS extraction#936pwnpope wants to merge 1 commit intoReFirmLabs:masterfrom
pwnpope wants to merge 1 commit intoReFirmLabs:masterfrom
Conversation
SquashFS extraction silently fails on systems without sasquatch installed, even when the standard unsquashfs tool is available. This adds a general-purpose fallback mechanism to the Extractor struct and uses it to fall back to unsquashfs when sasquatch is not found. Also fixes a pre-existing bug where carved files were not cleaned up when an external extractor command failed to launch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unsquashfsbut notsasquatch, which is the common case on most Linux distros. The extraction error is swallowed and the output directory cleaned up, so the user gets no extracted rootfs with no indication of why.fallbackfield to theExtractorstruct, allowing any external extractor to chain alternative tools.sasquatchtounsquashfsfor SquashFS extraction.Test plan
cargo test— all 29 tests passsasquatch— rootfs now extracts successfully viaunsquashfsfallbacksasquatchto confirm no regression