Updated ARC PBS to recognise Zeus submission error #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the changes in Zeus, unless the user is submitting arc via n170 host, they will not be informed there is a job submission error occurring and ARC will continuously say it cannot find the output files (even though it technically was never able to submit the ESS jobs). This PR will therefore error ARC if it receives such a message about job submission issues.
There was a problem hiding this comment.
Pull request overview
This PR adds error detection for PBS job submissions attempted from compute nodes on the Zeus cluster. Previously, when jobs were submitted from a compute node instead of the login server, ARC would silently fail and report missing output files without clearly indicating the underlying submission error.
Key Changes:
- Added error detection in
submit_job()to recognize Zeus PBS compute node submission errors - Added comprehensive test coverage for the new error handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| arc/job/local.py | Added error handling for PBS submissions from compute nodes, raising a clear ValueError when the specific error messages are detected |
| arc/job/local_test.py | Added unit test to verify the compute node error detection works correctly, including proper mocking of the retry behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes in Zeus, unless the user is submitting arc via n170 host, they will not be informed there is a job submission error occurring and ARC will continuously say it cannot find the output files (even though it technically was never able to submit the ESS jobs). This PR will therefore error ARC if it receives such a message about job submission issues.