Improve AutoTST dependency handling in job execution #816
+4
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the import-time check for the AutoTST module with a runtime check for the configured AutoTST Python executable, providing a clearer error message if it is missing. Original code was attempting to import AutoTST scripts when in reality we use AutoTST as a subprocess, so it did not make sense to be importing the actual scripts.
There was a problem hiding this comment.
Pull request overview
This PR improves AutoTST dependency handling by replacing an import-time module check with a runtime check for the AutoTST Python executable path. This is more appropriate since AutoTST is invoked as a subprocess rather than imported directly as a Python module.
Key Changes:
- Removed the
HAS_AUTOTSTimport-time flag and the attempt to importautotst.reaction.Reaction - Added a runtime check in
execute_incore()that validates theAUTOTST_PYTHONexecutable path before running AutoTST as a subprocess - Updated error handling to provide clearer guidance about configuring the
tst_envenvironment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the import-time check for the AutoTST module with a runtime check for the configured AutoTST Python executable, providing a clearer error message if it is missing. Original code was attempting to import AutoTST scripts when in reality we use AutoTST as a subprocess, so it did not make sense to be importing the actual scripts.