-
Notifications
You must be signed in to change notification settings - Fork 250
Arkane: add check for iop(2/9=2000) in Gaussian load geometry #2758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Arkane: add check for iop(2/9=2000) in Gaussian load geometry #2758
Conversation
|
This is currently failing the unit tests because the toluene and benzyl Arkane examples have Gaussian logfiles with more than 14 atoms. I'm rerunning these calculations to see how much it changes the results. If it's a lot, I'll replace the logfiles. If it's not much, that means I've been overstating the error due to this bug and I may not fully understand the problem I thought I was diagnosing. |
|
This pull request is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant pull request, otherwise it will automatically be closed in 30 days. |
|
@sevyharris I see that this PR fell off - want to revive? |
|
This pull request is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant pull request, otherwise it will automatically be closed in 30 days. |
|
This pull request is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant pull request, otherwise it will automatically be closed in 30 days. |
Motivation or Problem
By default, Gaussian only prints Cartesians in the input orientation for small cases. Add a check for the IOP(2/9=2000) keyword so users don't get tripped up like I did here: #2757 with coordinates that don't match the Hessian.
Description of Changes
I added a check for the IOP(2/9=2000 keyword) when loading the geometry. If the molecule has 14+ atoms (this seems to be the threshold according to my experiments), this will raise a LogError if the keyword hasn't been specified.
Testing
I tested this using one Gaussian logfile that has the IOP and one that doesn't.
conformer_0002_iop.log
conformer_0002_no_iop.log