[WIP] Solve memory leak in Promise::fromObservable#198
Open
WyriHaximus wants to merge 3 commits intoReactiveX:masterfrom
Open
[WIP] Solve memory leak in Promise::fromObservable#198WyriHaximus wants to merge 3 commits intoReactiveX:masterfrom
WyriHaximus wants to merge 3 commits intoReactiveX:masterfrom
Conversation
Contributor
|
Seems like I'm running into the same issue. @WyriHaximus Is this a problem that has to get fixed or is this eventually caught by GC? |
Contributor
Author
|
@bartvanhoutte I utterly forgot about this, well you have two kinds of memory leaks in PHP, the ones that the GC will clean up and the ones that the GC doesn't clean up. The ones the GC will clean up are ignorable until a certain point. The otherones aren't. So the question is, is the GC cleaning up what you are seeing? I'll get on this PR again soon and get it ready for review and merging 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress, don't merge yet. Going to commit in stages