Add support for react/promise v3#217
Merged
davidwdan merged 1 commit intoReactiveX:masterfrom Nov 27, 2023
Merged
Conversation
Contributor
Author
|
@davidwdan && @mbonneau I've also included the changes for type templates into this PR, do you prefer to have it in one big PR or split it into two? |
Member
|
@WyriHaximus I think doing that in a separate PR would make sense. I'm very excited about template support. |
WyriHaximus
force-pushed
the
promise-v3
branch
2 times, most recently
from
7dec0f8 to
1b94c3f
Compare
WyriHaximus
changed the title
With v3 come a whole list of [changes](https://github.com/reactphp/promise/releases/tag/v3.0.0) including end of promise chain detection, the removal of the `CancellablePromiseInterface` interface, and type templating.
Contributor
Author
|
@davidwdan Cool, moved that to #218 making this PR ready for review 🚀 . |
mbonneau
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With v3 come a whole list of changes including end of promise chain detection, the removal of the
CancellablePromiseInterfaceinterface, and type templating.