Refactor medical record API and enhance input validation#16
Merged
Conversation
…d and frontend types Standardizes field naming between request and response DTOs. Uses @value SpEL on projection interface to decouple JSON key from entity field.
… edit modal Shows patient info, doctor info, and record content. Edit button visible only to ROLE_DOCTOR via useAuthStore role check.
Expired tokens now trigger logout and redirect to login instead of letting the user through with a stale session that fails every API call. isTokenExpired extracted to utils/jwt.ts to reuse decodeJwt's safe base64url handling.
- Names: min 2, max 50 - Username: min 3, max 30, alphanumeric + underscore only - Email: type check - Phone: numeric pattern, 9-15 chars - Address: min 5 - Employee code: uppercase alphanumeric only - DOB: disallow future dates - Medical record description/advice: min 10, max 2000 with char count
…rdController Covers all 4 endpoints with @operation, @ApiResponses, and @parameter. Descriptions include ABAC rules, transactional side effects, and role requirements so consumers know exactly what to expect without reading service code.
Explains two-phase Keycloak + MySQL compensation on signup, token usage and lifetime on signin, and adds 503 response for Keycloak unavailability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.