Skip to content

WIP: net: Introduce dual-stream udn tests#4786

Open
azhivovk wants to merge 3 commits intoRedHatQE:mainfrom
azhivovk:new_rhcos9-10_tests_udn
Open

WIP: net: Introduce dual-stream udn tests#4786
azhivovk wants to merge 3 commits intoRedHatQE:mainfrom
azhivovk:new_rhcos9-10_tests_udn

Conversation

@azhivovk
Copy link
Copy Markdown
Contributor

@azhivovk azhivovk commented May 8, 2026

Short description:

New dual-stream tests: UDN scenarios

More details:

STD: #4569

What this PR does / why we need it:

Added automation for new dual-stream tests

Which issue(s) this PR fixes: -
Special notes for reviewer:

Follow-up implementation of new tests of primary UDN which is supported only for IPv4
Do not review the first infra commit - it'll be merged in first PR of this series #4772

jira-ticket: https://redhat.atlassian.net/browse/CNV-86194

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Warning

Rate limit exceeded

@azhivovk has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 49 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: df94cfb3-c59d-4476-95fc-3d9765d36a8b

📥 Commits

Reviewing files that changed from the base of the PR and between 37989ad and 38f8418.

📒 Files selected for processing (7)
  • libs/vm/spec.py
  • pytest.ini
  • tests/network/conftest.py
  • tests/network/libs/nodes.py
  • tests/network/libs/vm_factory.py
  • tests/network/user_defined_network/rhel9_rhel10_cluster/conftest.py
  • tests/network/user_defined_network/rhel9_rhel10_cluster/test_connectivity.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-virtualization-qe-bot-2
Copy link
Copy Markdown
Contributor

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • EdDev
  • dshchedr
  • myakove
  • rnetser
  • vsibirsk

Reviewers:

  • Anatw
  • EdDev
  • RoniKishner
  • azhivovk
  • dshchedr
  • frenzyfriday
  • nirdothan
  • orelmisan
  • rnetser
  • servolkov
  • vsibirsk
  • yossisegev
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

azhivovk and others added 3 commits May 8, 2026 12:24
- Add mixed_os_nodes marker to pytest.ini to select tests only on
  compatible clusters
- Add rhcos9_node/rhcos10_node fixtures to network conftest
- Add update_vm_node_selector helper and HOSTNAME_LABEL to nodes lib

Signed-off-by: Asia Khromov <azhivovk@redhat.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Asia Khromov <azhivovk@redhat.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
The l2bridge UDN binding depends on components that may behave
differently across RHCOS versions.
These tests verify that an active TCP connection over a primary
UDN is preserved when the server VM migrates between RHCOS 9 and
RHCOS 10 nodes in both directions.

Signed-off-by: Asia Khromov <azhivovk@redhat.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@azhivovk azhivovk force-pushed the new_rhcos9-10_tests_udn branch from 30236fa to 38f8418 Compare May 8, 2026 09:29
@azhivovk
Copy link
Copy Markdown
Contributor Author

azhivovk commented May 8, 2026

Change: Drop localnet changes

@azhivovk
Copy link
Copy Markdown
Contributor Author

azhivovk commented May 8, 2026

/wip

@openshift-virtualization-qe-bot-3 openshift-virtualization-qe-bot-3 changed the title net: Introduce dual-stream udn tests WIP: net: Introduce dual-stream udn tests May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants