Fix UIKit thread error in AppInfo and DeviceDisplay platform handlers#35
Merged
Fix UIKit thread error in AppInfo and DeviceDisplay platform handlers#35
Conversation
AppInfo.Current (RequestedTheme, RequestedLayoutDirection) and DeviceDisplay.MainDisplayInfo access UIKit APIs that must be called on the main thread. The HTTP server handlers run on a background thread, causing 'UIKit Consistency error' on iOS. Wrap both handlers in MainThread.InvokeOnMainThreadAsync() to dispatch to the UI thread before accessing these APIs. Fixes #34 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34
/api/platform/app-infoand/api/platform/device-displayfail on iOS with:Changes
Wrap both handlers in
MainThread.InvokeOnMainThreadAsync()to dispatch UIKit-dependent API calls to the main thread:HandlePlatformAppInfo—AppInfo.Current.RequestedThemeandRequestedLayoutDirectionrequire UIKitHandlePlatformDeviceDisplay—DeviceDisplay.MainDisplayInforequires UIKitOther platform handlers (
DeviceInfo,Battery,Connectivity,VersionTracking) work fine from background threads and don't need this change.Testing