Fix preferences listing crash with non-string types on Android#40
Merged
Conversation
Android SharedPreferences stores typed values (int, bool, double, etc.) and throws ClassCastException when reading with the wrong type. The List handler always called Preferences.Get<string> which crashes when int or other non-string values exist. Added ReadPreferenceValue helper that tries each supported type in order (string, int, bool, double, long, float) catching cast failures. Used by both List and Get (when no type param specified). List response now includes a 'type' field for each entry. Fixes: Storing an int preference then listing would return 'java.lang. Integer cannot be cast to java.lang.String' and hide all preferences. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
Android's
SharedPreferencesstores typed values natively and throwsClassCastExceptionwhen you try to read anintas astring.Changes
ReadPreferenceValue(key, sharedName)helper that tries each supported type in order (string → int → bool → double → long → float), catching cast failurestypequery param is specified (auto-detect)typefield for each entryTesting
Tested by storing an int preference on Android via
POST /api/preferences/myIntwith{"value": 42, "type": "int"}, then verifyingGET /api/preferencesreturns all preferences including the int withtype: "int".