This repository was archived by the owner on Jul 27, 2021. It is now read-only.
[MIRROR] Ports #44391 and #48637 from TGStation #605
Open
ghost wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: BeeStation/BeeStation-Hornet#4755
About The Pull Request
I compared /TG/'s code and ours and this is literally the only difference and somehow this fixes it. Doesnt break anything as far as I tested.PR in question
PR 2 in question
turns out the rune chat port missed some stuff that magically only broke voice sensor nanites. This fixes that and cleans up some other hearing procs.
Title
Why It's Good For The Game
Bugs bad, voice sensor memes good
Changelog
🆑
fix: Voice Sensor Nanites
fix: Traitor codewords (thanks bosnia)
refactor: Alot of on_hear() changed to signals
/:cl: