AB#129867 improve-search-functionality-in-summary-cards-grids #1233
Open
GhaziAlibi wants to merge 1 commit intonextfrom
Open
AB#129867 improve-search-functionality-in-summary-cards-grids #1233GhaziAlibi wants to merge 1 commit intonextfrom
GhaziAlibi wants to merge 1 commit intonextfrom
Conversation
…efactoring global search logic Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the global search in summary cards and grids returning every record instead of filtering by the searched string.
Root cause
The frontend
searchFilters()helper emitted a sub-rule for every field of the resource, including date / datetime fields. When the searched string was not a parseable date (e.g."2026-E00000017"), the backend'sgetDateForMongo()producednullboundaries, yielding{ $gte: null, $lte: null }clauses inside the global-search$or. Those clauses matched every document where the date field was missing, so the$oreffectively matched everything.Fix
search-filters.ts): skipdate/datetime/datetime-localrules unless the search string parses as a valid date.getFilter.ts): when expanding_globalSearchinto an$or, drop any sub-filter containing a comparison againstnull/undefined/ invalidDate(defense in depth).Type of change
How Has This Been Tested?
incrementalIdlike2026-E00000017).Screenshots
Checklist:
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145