Add CMake compatibility, cleanup/improve project structure#35
Open
CodeFinder2 wants to merge 2 commits intoReneNyffenegger:masterfrom
Open
Add CMake compatibility, cleanup/improve project structure#35CodeFinder2 wants to merge 2 commits intoReneNyffenegger:masterfrom
CodeFinder2 wants to merge 2 commits intoReneNyffenegger:masterfrom
Conversation
|
Regarding the command not found error, I would update the Makefile as follows: which instructs the test recipe to run the binaries from the local directory and ignore any returned error, so both tests run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for this library! :-)
I've added CMake support in order to integrate it in my (CMake) project using CPM.
Along the way, I've also revisited the project's directory structure to more adhere to modern C++ project structures, especially placing headers in
include/$name_of_the_project/to avoid conflicts with equally named headers of other projects (if any).Would be glad if you could take a look and merge this! :-)
PS: I also updated your
Makefilebut it fails withHowever, I already got this error before (after just cloning your repo) so it should not be an issue caused by my modifications.