Skip to content

Refactor ExpertResultCard and OutreachDetailPageContent for improved … #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nicktytarenko wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor ExpertResultCard and OutreachDetailPageContent for improved … #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions app/expert-finder/library/[searchId]/components/ExpertResultCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,14 @@ export function ExpertResultCard({
)}
>
<div className="flex items-start justify-between gap-2 mb-2">
<header className="min-w-0 flex-1">
<div className="flex flex-wrap items-center gap-x-2 gap-y-1">
<h3 className="text-base font-semibold text-gray-900 shrink-0">{name || '—'}</h3>
<header className="min-w-0 flex-1 pr-1">
<div className="flex min-w-0 flex-wrap items-center gap-x-2 gap-y-1">
<h3
className="min-w-0 max-w-full break-words text-base font-semibold text-gray-900"
title={name || undefined}
>
{name || '—'}
</h3>
{sources.length > 0
? sources.map((src, i) => (
<a
Expand Down
2 changes: 1 addition & 1 deletion app/expert-finder/library/[searchId]/outreach/[emailId]/OutreachDetailPageContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ export function OutreachDetailPageContent({
)}
</div>

{(isClosed || email.status === 'sent') && email.notes?.trim() ? (
{isClosed && email.notes?.trim() ? (
<div className="rounded-lg border border-gray-200 bg-gray-50 px-4 py-3">
<p className="text-xs font-semibold text-gray-600 uppercase tracking-wide">Notes</p>
<p className="text-sm text-gray-800 mt-1 whitespace-pre-wrap">{email.notes}</p>
Expand Down