Skip to content

Develop#117

Merged
ucswift merged 2 commits into
masterfrom
develop
Apr 15, 2026
Merged

Develop#117
ucswift merged 2 commits into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Apr 15, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated storage library dependency for enhanced stability and compatibility.

@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated the react-native-mmkv package dependency version constraint in package.json from ~3.1.0 to ~3.3.3, allowing the use of a newer minor version range of the MMKV storage library.

Changes

Cohort / File(s) Summary
Dependency Update
package.json
Bumped react-native-mmkv version constraint from ~3.1.0 to ~3.3.3

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version bump, so small yet grand,
MMKV now runs across the land,
From 3.1 to 3.3 it flies,
Performance blooms before our eyes! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Develop' is vague and generic; it does not describe the actual change (updating react-native-mmkv dependency). Provide a more descriptive title that reflects the main change, such as 'Update react-native-mmkv to 3.3.3' or 'Upgrade react-native-mmkv dependency'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 171: Update verification: confirm react-native-mmkv@~3.3.3 is safe to
merge by validating build compatibility for our RN 0.81.5 + Expo SDK 54 setup;
check the react-native-mmkv changelog/release notes for 3.2.x→3.3.x, run iOS pod
install and a full ios build (including prebuild if using Expo prebuild), run
Android gradle assemble/build, and apply any documented patches/workarounds if
pod install or native builds fail; reference the dependency line
"react-native-mmkv": "~3.3.3" when updating package.json or adding fixes and
ensure no runtime API breaks compared to 3.1.x in our usage.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 054f0ff2-0348-48b6-8e17-bedf05e53c03

📥 Commits

Reviewing files that changed from the base of the PR and between 01a99d5 and e5fd013.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json

Comment thread package.json
"react-native-keyboard-controller": "1.18.5",
"react-native-logs": "~5.3.0",
"react-native-mmkv": "~3.1.0",
"react-native-mmkv": "~3.3.3",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

Is react-native-mmkv 3.3.3 compatible with React Native 0.81.x and Expo SDK 54? Please include any documented breaking changes between react-native-mmkv 3.1.x and 3.3.x, especially around MMKV constructor options, encryptionKey behavior, and getString/set/delete/useMMKVBoolean APIs.

💡 Result:

No, react-native-mmkv 3.3.3 is not fully compatible with React Native 0.81.x and Expo SDK 54 out-of-the-box. While users have successfully used it with RN 0.81.x after applying patches or updates (e.g., CMake C++ standard fix in 3.3.1+), there are build issues on Android and iOS prebuild that require workarounds or specific versions like 3.3.1 or 3.3.3. For Expo SDK 54 (RN 0.81.4), 3.3.3 fixes a Codegen pod install error seen in 3.3.2. Documented breaking changes between 3.1.x and 3.3.x are minimal within minor releases; major changes were in 3.0.0 (requires RN >=0.74, new arch/TurboModules): - Buffer APIs: Uint8Array -> ArrayBuffer. - set/recrypt now properly throw on failure. No explicit breaking changes in constructor options, encryptionKey behavior, or getString/set/delete/useMMKVBoolean APIs between 3.1.x and 3.3.x. Encryption fixes (e.g., long keys) were in 3.0.0. Later V4 introduces encrypt/decrypt replacing recrypt, but not relevant here. Sources confirm usage with patches for RN 0.81/Expo 54, but recommend V4 for newer RN (0.82+) or checking official docs for exact compat.

Citations:


🏁 Script executed:

cat package.json | grep -E '"react-native"|"expo"' | head -20

Repository: Resgrid/BigBoard

Length of output: 125


Confirm react-native-mmkv@~3.3.3 build compatibility before merge.

This version bump moves to 3.3.3 for React Native 0.81.5 + Expo SDK 54, a combination with documented Android/iOS build issues requiring patches or workarounds. While 3.3.3 fixes the pod install error from 3.3.2, review known build concerns and confirm your prebuild/native build setup handles this version. No API breaking changes exist between 3.1.x and 3.3.x.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 171, Update verification: confirm
react-native-mmkv@~3.3.3 is safe to merge by validating build compatibility for
our RN 0.81.5 + Expo SDK 54 setup; check the react-native-mmkv changelog/release
notes for 3.2.x→3.3.x, run iOS pod install and a full ios build (including
prebuild if using Expo prebuild), run Android gradle assemble/build, and apply
any documented patches/workarounds if pod install or native builds fail;
reference the dependency line "react-native-mmkv": "~3.3.3" when updating
package.json or adding fixes and ensure no runtime API breaks compared to 3.1.x
in our usage.

@ucswift

ucswift commented Apr 15, 2026

Copy link
Copy Markdown
Member Author

Approve

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit d9253ee into master Apr 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant