remove if properties or their types has got ExcludeProxy Attribute#122
Open
Rakkoc wants to merge 1 commit intoRestCode:masterfrom
Open
remove if properties or their types has got ExcludeProxy Attribute#122Rakkoc wants to merge 1 commit intoRestCode:masterfrom
Rakkoc wants to merge 1 commit intoRestCode:masterfrom
Conversation
remove if properties or their types has got ExcludeProxy Attribute (or dummy name)
Collaborator
|
What's the use-case of this; as opposed to just marking the properties as |
Author
|
I use same dll with abstract (base) class and same type (they are nullable) use an other project and i can modify it. But they are partial i can add attribute in my project. And public it if i know name. |
faniereynders
requested changes
Jun 20, 2017
| // remove if properties or their types has got ExcludeProxy Attribute (or dummy name) | ||
| properties = properties.Where(x => | ||
| !x.CustomAttributes.Any(z => z.AttributeType.Name.Contains("ExcludeProxy")) && // Property | ||
| !x.PropertyType.CustomAttributes.Any(y => y.AttributeType.Name.Contains("ExcludeProxy")) // Type |
Member
There was a problem hiding this comment.
Avoid magic strings where possible.
An idea is to either compare to nameof(ExcludeProxy) or just compare where types contain typeof(ExcludeProxy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove if properties or their types has got ExcludeProxy Attribute (or dummy name)