Fix: Unknown props warning in React 15.2.1, ES6'ize, add sheet caching, better regex for matching selectors#16
Open
luigiplr wants to merge 10 commits intoRickWong:masterfrom
Open
Fix: Unknown props warning in React 15.2.1, ES6'ize, add sheet caching, better regex for matching selectors#16luigiplr wants to merge 10 commits intoRickWong:masterfrom
luigiplr wants to merge 10 commits intoRickWong:masterfrom
Conversation
also bring component up to es6 spec
allows matching of "input[type="checkbox"]"
particularly helpful with larger stylesheets.
|
I've been noticing these little buggers warnings lately. Would be great to have them go away! :-) |
Owner
|
Thanks guys I will merge this later today. |
Collaborator
|
@luigiplr I don't think the conflicts are major. Would you mind rebasing your branch onto master so we can get this merged? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes the following warning when used with React
15.2.1https://fb.me/react-unknown-prop
Other changes include: