Fixed abilities applying hediffs#15
Open
SokyranTheDragon wants to merge 1 commit intoRim-Effect-Legacy:developmentfrom
Open
Fixed abilities applying hediffs#15SokyranTheDragon wants to merge 1 commit intoRim-Effect-Legacy:developmentfrom
SokyranTheDragon wants to merge 1 commit intoRim-Effect-Legacy:developmentfrom
Conversation
Looking at `VFECore.Abilities.Ability:ApplyHediff`, it uses `durationTime` and applies it to `HediffCompProperties_Disappears`, even if `durationTime` is 0. I believe this was changed at some point, but those abilities and hediffs weren't updated for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at
VFECore.Abilities.Ability:ApplyHediff, it usesdurationTimeand applies it toHediffCompProperties_Disappears, even ifdurationTimeis 0. I believe this was changed at some point, but those abilities and hediffs weren't updated for that.This also affects Rim-Effect: N7, for which I've also made a PR.
Rim-Effect: Asari and Reapers also suffers from this, however I am unable to make a PR because as far as I'm aware it's not on GitHub (or not as easy to find as the rest of the mods).