Skip to content

Test on PHP 8.3 & 8.4#55

Closed
GrahamCampbell wants to merge 1 commit intoRiverline:masterfrom
GrahamCampbell:patch-1
Closed

Test on PHP 8.3 & 8.4#55
GrahamCampbell wants to merge 1 commit intoRiverline:masterfrom
GrahamCampbell:patch-1

Conversation

@GrahamCampbell
Copy link

No description provided.

@rcambien
Copy link
Contributor

Tests failed due to dev requirements.

The range of PHP version is so large, this version constraint doesn't make any sense, that's why i never merge #53

I think the best solution is to remove all dev requirements and add composer require ... commands in a workflow step and let composer choose the best version for the current environment.

Or replace all dev requirements version constraints with a * but i don't know if it will solve the problem.

What do you think ?

@GrahamCampbell
Copy link
Author

I think it would be reasonable to drop older PHP versions, and only support PHP 7.4 and up. I feel that it's more important that we validate compatibility with the newer PHP versions than maintain support for super old versions. The older versions of this package still remain available for those who can't upgrade.

@rcambien
Copy link
Contributor

Fixed in #56

@rcambien rcambien closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants