fix: bitmap advance_back_to could violate invariants#339
Merged
Kerollmops merged 1 commit intoRoaringBitmap:mainfrom Jul 31, 2025
Merged
fix: bitmap advance_back_to could violate invariants#339Kerollmops merged 1 commit intoRoaringBitmap:mainfrom
Kerollmops merged 1 commit intoRoaringBitmap:mainfrom
Conversation
Bitmap container iterators require the front key <= the back key at all times, but advance_back_to could violate this. This shouldn't have really caused any misbehavior, but would trigger a debug assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitmap container iterators require the front key <= the back key at all times, but advance_back_to could violate this. This shouldn't have really caused any misbehavior, but would trigger a debug assertion.