Remove SIMD LaneCount, SupportedLaneCount with upstream changes#347
Remove SIMD LaneCount, SupportedLaneCount with upstream changes#347xangelix wants to merge 3 commits intoRoaringBitmap:mainfrom
Conversation
Kerollmops
left a comment
There was a problem hiding this comment.
Nice 👌 Thank you very much @xangelix for the change. Let's see where it goes.
Can you tell me if I need to land your changes to crates.io so that people can use the simd feature with the latest rustc compile, please?
Kerollmops
left a comment
There was a problem hiding this comment.
Would you mind rebasing on #349, please? It's odd because it seems to me that your PR will fix nightly, but will break the stable CI...
|
I would be happy to rebase so your CICD can work! But to be clear, I don't think this PR breaks stable.
If you want to support nightly versions roughly after Separately about the CICD, If you check with
it's Precisely v3.25.0, https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md#3250 which was released 15 days ago https://crates.io/crates/tempfile/3.25.0. Meaning that for 15 days now, your CICD would fail even if you ran your main branch on it. (So the CICD was already broken Anyways, sorry for the ramble! I think this PR is just a matter of which nightly versions you might want to support. So, it's not necessary to bump the MSRV for this PR if you don't want to. Correct me if I'm wrong! 😛 Rebasing now... |
ac2183e to
817be47
Compare

Not sure exactly when this will be part of a versioned release? As such this is marked draft. This contains the required changes for SIMD compilation on the latest nightly toolchain.
See rust-lang/rust@b71ff51.