Skip to content

Comments

chore: resolve all missing_const_for_fn clippy lints#348

Open
xangelix wants to merge 1 commit intoRoaringBitmap:mainfrom
xangelix:clippy-missing_const_for_fn
Open

chore: resolve all missing_const_for_fn clippy lints#348
xangelix wants to merge 1 commit intoRoaringBitmap:mainfrom
xangelix:clippy-missing_const_for_fn

Conversation

@xangelix
Copy link

24x missing_const_for_fn

@xangelix xangelix marked this pull request as ready for review February 16, 2026 16:39
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @xangelix, for the changes. As far as I can tell, only the NonSortedIntegers::valid_until method is a user-facing one (a public method). I think it's good to be merged 👍

@xangelix
Copy link
Author

xangelix commented Feb 24, 2026

Hi @Kerollmops ! You're welcome-- happy to contribute.

Both RoaringBitmap::new() and RoaringTreemap::new() are made const with this PR as far as I can tell? Which was the primary reason for this PR. Among other public methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants