Fix RuntimeError by ensuring attn_mask is None when is_causal=True#1
Open
IgorAherne wants to merge 2 commits into
Open
Fix RuntimeError by ensuring attn_mask is None when is_causal=True#1IgorAherne wants to merge 2 commits into
IgorAherne wants to merge 2 commits into
Conversation
Author
|
Hm, looking at my proposed changes, there is more than necessary somehow. I wanted to only offer this change: |
Author
|
ok, much less intrusive now, see Files Changed tab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents an error by modifying the Attention module: avoid passing an explicit attn_mask to F.scaled_dot_product_attention when is_causal=True.
This allows the function's internal causal masking mechanism to be used without conflict, during operations like decoder prefill.
Otherwise getting the following error: