chore(sdk): drop ignore_errors from materialize#136
Merged
Conversation
The materialize operation no longer accepts ignore_errors — it was removed server-side because ladybug 0.18's COPY (ignore_errors=true) silently drops valid rows. Regenerate MaterializeOp without the field and drop it from the MaterializationOptions facade + tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop
ignore_errorsfrom the materialize surface. The API removed the field server-side because LadybugDB 0.18'sCOPY (ignore_errors=true)silently drops valid rows in proportion to batch size — so the flag is gone fromMaterializeOp, and the facade should no longer send it.Changes
MaterializeOpwithout theignore_errorsfield (model + serde).MaterializationOptionsfacade: removed theignore_errorsoption;GraphClient.materialize()no longer passes it toMaterializeOp.MaterializationOptionstests.Compatibility
Removing an optional field. Old callers that set
MaterializationOptions(ignore_errors=…)will need to drop the kwarg, but no behavior changes — the server ignored the value anyway on the current API and now doesn't accept it.Testing