Skip to content

fix: 'emojiOne assets is no longer supported hence it's a good idea to shift to emoji toolkit'#30008

Closed
Daksh-10 wants to merge 4 commits into
RocketChat:developfrom
Daksh-10:Daksh/#24917
Closed

fix: 'emojiOne assets is no longer supported hence it's a good idea to shift to emoji toolkit'#30008
Daksh-10 wants to merge 4 commits into
RocketChat:developfrom
Daksh-10:Daksh/#24917

Conversation

@Daksh-10

@Daksh-10 Daksh-10 commented Aug 3, 2023

Copy link
Copy Markdown

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Aug 3, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ed2847d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant

CLAassistant commented Aug 3, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Daksh-10 Daksh-10 changed the title changed 'emojione-assets' in assetFolder constant variable to 'emoji-toolkit' fix: changed 'emojione-assets' in assetFolder constant variable to 'emoji-toolkit' Aug 3, 2023
@Daksh-10 Daksh-10 changed the title fix: changed 'emojione-assets' in assetFolder constant variable to 'emoji-toolkit' fix: changed 'emojiOne assets is no longer supported hence it's a good idea to shift to emoji toolkit' Aug 9, 2023
@Daksh-10 Daksh-10 changed the title fix: changed 'emojiOne assets is no longer supported hence it's a good idea to shift to emoji toolkit' fix: 'emojiOne assets is no longer supported hence it's a good idea to shift to emoji toolkit' Aug 9, 2023
@Daksh-10

Daksh-10 commented Aug 9, 2023

Copy link
Copy Markdown
Author

Request for a review for the commits

@codecov

codecov Bot commented Aug 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #30008 (1afa33b) into develop (6098941) will increase coverage by 17.31%.
The diff coverage is n/a.

❗ Current head 1afa33b differs from pull request most recent head ed2847d. Consider uploading reports for the commit ed2847d to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #30008       +/-   ##
============================================
+ Coverage    50.44%   67.75%   +17.31%     
============================================
  Files          819       86      -733     
  Lines        15206     1771    -13435     
  Branches      2770      379     -2391     
============================================
- Hits          7670     1200     -6470     
+ Misses        7116      510     -6606     
+ Partials       420       61      -359     
Flag Coverage Δ
e2e ?
unit 67.75% <ø> (+10.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@engelgabriel

Copy link
Copy Markdown
Member

Closing this PR in favor of #39411, where we’re replacing Emojione with native Unicode emojis.

It’s still a draft, and we’d love help from the community to get it across the finish line 🙌

@github-project-automation github-project-automation Bot moved this from To Do to Done in Community Task Force Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

7 participants