-
Notifications
You must be signed in to change notification settings - Fork 13.7k
chore: Update JoyPixels emoji icons #38098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
shreeya-methuku
wants to merge
1
commit into
RocketChat:develop
from
shreeya-methuku:update-joypixels-emoji
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@rocket.chat/meteor': patch | ||
| --- | ||
|
|
||
| Updates emoji-toolkit dependency to version 9.0.0 for newer emoji support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: RocketChat/Rocket.Chat
Length of output: 414
🌐 Web query:
emoji-toolkit v9.0.0 breaking changes release notes changelog💡 Result:
Summary — emoji-toolkit v9.0.0
Links / sources
[1] GitHub — joypixels/emoji-toolkit releases (v9.0.0 entry). (github.com)
[2] JoyPixels / JoyPixels 9.0 (Emoji 15.1 changelog / blog). (blog.emojipedia.org)
[3] npm package page for emoji-toolkit (versions / release info). (npmjs.com)
If you want, I can extract the exact files changed in the v9.0.0 tag (diff), or paste the full release text/assets.
Citations:
🏁 Script executed:
Repository: RocketChat/Rocket.Chat
Length of output: 1663
🌐 Web query:
emoji-toolkit v7 to v9 API breaking changes migration guide💡 Result:
Here’s a concise migration checklist and the important breaking changes when moving emoji-toolkit (JoyPixels) from v7 → v9, with links to the project sources to verify details.
Quick summary (actionable items)
Minimal migration steps
References
If you want, I can:
Sources
[1] joypixels/emoji-toolkit — GitHub repository (README + UPGRADE).
[2] emoji-toolkit changelog / package history (yarn/npm changelog entries showing v8/v7 notes).
[3] emoji-toolkit — npm package page (current versions & install info).
🏁 Script executed:
Repository: RocketChat/Rocket.Chat
Length of output: 3560
emoji-toolkit v9.0.0 requires substantial refactoring—current integration is incompatible with the breaking changes.
Version 9.0.0 exists and is stable, but the upgrade introduces major breaking changes that are not reflected in the current codebase:
emoji.packages.emojione, expects.emojioneCSS classes, and uses legacy "emojione" identifiers throughout.toShort(), but no comprehensive API definition exists to verify compatibility with the broader emoji-toolkit v9 API.Before merging, either:
emoji.packages.emojione→emoji.packages.joypixels, update CSS class selectors (.emojione→.emoji), and refactor emoji data loading to match the v9 structure.No active security vulnerabilities were found for v9.0.0.
🤖 Prompt for AI Agents