chore: message parser limit on the client#40600
Open
gabriellsh wants to merge 14 commits into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
|
Looks like this PR is ready to merge! 🎉 |
|
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughIntroduces a configurable markdown parsing length limit sourced from a ChangesMarkdown Parser Length Limit
Sequence DiagramsequenceDiagram
participant Client as MarkdownText Component
participant Limit as getMarkdownParserLimit()
participant Inner as MarkdownTextInner
participant Marked as marked.parse()
participant DOMPurify as DOMPurify.sanitize()
Client->>Limit: check content.length
Limit-->>Client: return parsed limit
alt content length exceeds limit
Client->>Client: render plain Box
else within limit
Client->>Inner: delegate with props
Inner->>Marked: parse content
Marked-->>Inner: HTML string
Inner->>DOMPurify: sanitize HTML
DOMPurify-->>Inner: cleaned HTML
Inner->>Inner: replace internal-link tokens
Inner-->>Client: rendered output
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #40600 +/- ##
===========================================
+ Coverage 70.08% 70.17% +0.09%
===========================================
Files 3357 3366 +9
Lines 129543 129867 +324
Branches 22474 23066 +592
===========================================
+ Hits 90787 91132 +345
+ Misses 35456 35415 -41
- Partials 3300 3320 +20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
nazabucciarelli
changed the title
…e/markdownParserLimitClient
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the client-side rendering/parsing behavior with the server’s new MESSAGE_MAX_PARSE_LENGTH setting by skipping markdown parsing when message text exceeds the configured limit, falling back to plain-text rendering.
Changes:
- Add client-side limit resolution (
rc-message-parser-max-lengthmeta) and caching utilities (getPageMeta,getMarkdownParserLimit). - Enforce the limit in key parsing/rendering paths (
parseMessageTextToAstMarkdown,normalizeThreadMessage,MarkdownText, omnichannel contact history). - Add unit tests covering limit behavior across parsing and UI components.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/meteor/client/views/omnichannel/contactHistory/MessageList/ContactHistoryMessage.tsx | Render plain message.msg when md is absent (e.g., parsing skipped). |
| apps/meteor/client/lib/parseMessageTextToAstMarkdown.ts | Skip parsing and return a plain-text AST when text exceeds the configured limit. |
| apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts | Add tests for “over limit” plain-text AST behavior (message + attachments). |
| apps/meteor/client/lib/normalizeThreadMessage.tsx | Apply the parser limit to thread preview normalization, falling back to plain-text tokens. |
| apps/meteor/client/lib/normalizeThreadMessage.spec.tsx | Add tests validating “within limit” vs “over limit” behavior and error handling. |
| apps/meteor/client/lib/getPageMeta.ts | Add meta tag reader with in-memory caching. |
| apps/meteor/client/lib/getPageMeta.spec.ts | Add tests for meta reading and caching behavior. |
| apps/meteor/client/lib/getMarkdownParserLimit.ts | Resolve the markdown parser limit from meta/default constant with “0 disables” semantics. |
| apps/meteor/client/lib/getMarkdownParserLimit.spec.ts | Add tests for limit resolution from meta/default constant. |
| apps/meteor/client/components/message/content/attachments/QuoteAttachment.tsx | Adjust quote rendering fallback when md is missing (but introduces a regression risk). |
| apps/meteor/client/components/MarkdownTextInner.tsx | Extract previous MarkdownText parsing/sanitization implementation into an inner component. |
| apps/meteor/client/components/MarkdownText.tsx | Add limit-based early return to render plain text without parsing. |
| apps/meteor/client/components/MarkdownText.spec.tsx | Add tests for limit-based plain-text vs parsed rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
QA Report — PR #40600 Tested locally with MESSAGE_MAX_PARSE_LENGTH=100 (and 0 for regression check). All 14 cases passed:
Note: The limit uses strict > — a message of exactly 100 chars still renders markdown, only from 101 onward, parsing is skipped. Just flagging in case the intent was >=. |
FragaKrummenauer
added
the
stat: QA assured
coderabbitai
Bot
added
the
type: feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (2)
apps/meteor/client/lib/getMarkdownParserLimit.spec.ts (1)
40-67: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winAdd malformed-number format tests to lock parser behavior.
Please add cases for values like
"100abc"and"1e3"so the suite enforces strict numeric acceptance and prevents future regressions around permissive parsing.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/meteor/client/lib/getMarkdownParserLimit.spec.ts` around lines 40 - 67, The test suite for getMarkdownParserLimit is missing coverage for edge cases with malformed numeric formats that could expose permissive parsing behavior. Add two new test cases after the existing tests: one that mocks getPageMetaMock.mockReturnValue with '100abc' to verify handling of numbers with appended non-numeric characters, and another with '1e3' to verify handling of scientific notation. Both should verify the expected behavior of getMarkdownParserLimit() against the intended strict numeric acceptance rules to prevent future regressions around parsing edge cases.apps/meteor/client/components/MarkdownTextInner.tsx (1)
108-114: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winRemove inline implementation comments to match repo style.
These comments are explanatory but violate the implementation-style rule for TS/TSX files.
As per coding guidelines, "Avoid code comments in the implementation".
Also applies to: 123-143, 180-183
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/meteor/client/components/MarkdownTextInner.tsx` around lines 108 - 114, Remove all inline implementation comments from the MarkdownTextInner.tsx file to align with the repository's coding style guidelines. Specifically, delete the comments explaining the INTERNAL_LINK_TOKEN constant generation, the purpose of marking internal links, and the dompurify.addHook registration at the module level (including comments about preventing memory leaks and hook sharing across instances). The comments appear before the INTERNAL_LINK_TOKEN declaration and before the dompurify.addHook call, as well as in other locations noted in the review (lines 123-143 and 180-183). Keep the actual code implementation unchanged, removing only the explanatory comment lines.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/meteor/client/lib/getMarkdownParserLimit.ts`:
- Around line 10-16: The getMarkdownParserLimit function uses parseInt which
accepts partial numeric strings like "100abc", causing incorrect validation of
malformed meta values. Replace the parseInt call with Number() for strict
numeric conversion, and change the Number.isFinite() validation to
Number.isInteger() to properly reject non-integer and partially-numeric strings
while still handling all expected cases (positive integers, zero, negatives, and
invalid input). The return logic comparing against zero and returning Infinity
should remain unchanged.
In `@apps/meteor/client/lib/getPageMeta.ts`:
- Around line 10-11: In the catch block of the getPageMeta function, the null
return value is not being cached in MetaCache, causing repeated calls for the
same key to repeatedly hit the failing path instead of returning a cached
result. Cache the null value in MetaCache (using the same key mechanism as the
success path) before returning null from the exception handler to ensure
consistent behavior with other null outcomes.
In `@apps/meteor/client/lib/normalizeThreadMessage.spec.tsx`:
- Around line 63-66: The test case for normalizeThreadMessage has a
contradictory expectation: it creates an attachment with only a description
field (description: 'desc') but expects the function to return null. However,
normalizeThreadMessage actually returns the description content when an
attachment has a description. Update the test expectation in the it block
starting at line 63 to expect the actual return value of the description
('desc') instead of null, making the test consistent with the actual behavior of
the normalizeThreadMessage function.
In
`@apps/meteor/client/views/omnichannel/contactHistory/MessageList/ContactHistoryMessage.tsx`:
- Around line 120-123: The MessageBody component at the conditional block
wrapping MessageContentBody creates duplicate wrappers because
MessageContentBody already renders MessageBody internally. Refactor the
conditional logic so that when message.md exists, render MessageContentBody
directly without the outer MessageBody wrapper, and when message.md does not
exist, render message.msg inside MessageBody. This eliminates the nested
MessageBody wrappers for the markdown content path.
---
Nitpick comments:
In `@apps/meteor/client/components/MarkdownTextInner.tsx`:
- Around line 108-114: Remove all inline implementation comments from the
MarkdownTextInner.tsx file to align with the repository's coding style
guidelines. Specifically, delete the comments explaining the INTERNAL_LINK_TOKEN
constant generation, the purpose of marking internal links, and the
dompurify.addHook registration at the module level (including comments about
preventing memory leaks and hook sharing across instances). The comments appear
before the INTERNAL_LINK_TOKEN declaration and before the dompurify.addHook
call, as well as in other locations noted in the review (lines 123-143 and
180-183). Keep the actual code implementation unchanged, removing only the
explanatory comment lines.
In `@apps/meteor/client/lib/getMarkdownParserLimit.spec.ts`:
- Around line 40-67: The test suite for getMarkdownParserLimit is missing
coverage for edge cases with malformed numeric formats that could expose
permissive parsing behavior. Add two new test cases after the existing tests:
one that mocks getPageMetaMock.mockReturnValue with '100abc' to verify handling
of numbers with appended non-numeric characters, and another with '1e3' to
verify handling of scientific notation. Both should verify the expected behavior
of getMarkdownParserLimit() against the intended strict numeric acceptance rules
to prevent future regressions around parsing edge cases.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5da2d138-32c8-4a8a-ba98-52a3c22ccc39
📒 Files selected for processing (12)
apps/meteor/client/components/MarkdownText.spec.tsxapps/meteor/client/components/MarkdownText.tsxapps/meteor/client/components/MarkdownTextInner.tsxapps/meteor/client/lib/getMarkdownParserLimit.spec.tsapps/meteor/client/lib/getMarkdownParserLimit.tsapps/meteor/client/lib/getPageMeta.spec.tsapps/meteor/client/lib/getPageMeta.tsapps/meteor/client/lib/normalizeThreadMessage.spec.tsxapps/meteor/client/lib/normalizeThreadMessage.tsxapps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.tsapps/meteor/client/views/omnichannel/contactHistory/MessageList/ContactHistoryMessage.tsx
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Hacktron Security Check
- GitHub Check: 🔨 Test Unit / Unit Tests
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/lib/getMarkdownParserLimit.tsapps/meteor/client/lib/getPageMeta.spec.tsapps/meteor/client/lib/getMarkdownParserLimit.spec.tsapps/meteor/client/lib/getPageMeta.tsapps/meteor/client/views/omnichannel/contactHistory/MessageList/ContactHistoryMessage.tsxapps/meteor/client/lib/normalizeThreadMessage.tsxapps/meteor/client/lib/normalizeThreadMessage.spec.tsxapps/meteor/client/components/MarkdownText.spec.tsxapps/meteor/client/lib/parseMessageTextToAstMarkdown.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.tsapps/meteor/client/components/MarkdownTextInner.tsxapps/meteor/client/components/MarkdownText.tsx
**/*.spec.ts
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use.spec.tsextension for test files (e.g.,login.spec.ts)
Files:
apps/meteor/client/lib/getPageMeta.spec.tsapps/meteor/client/lib/getMarkdownParserLimit.spec.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts
🧠 Learnings (8)
📚 Learning: 2026-02-10T16:32:42.586Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 38528
File: apps/meteor/client/startup/roles.ts:14-14
Timestamp: 2026-02-10T16:32:42.586Z
Learning: In Rocket.Chat's Meteor client code, DDP streams use EJSON and Date fields arrive as Date objects; do not manually construct new Date() in stream handlers (for example, in sdk.stream()). Only REST API responses return plain JSON where dates are strings, so implement explicit conversion there if needed. Apply this guidance to all TypeScript files under apps/meteor/client to ensure consistent date handling in DDP streams and REST responses.
Applied to files:
apps/meteor/client/lib/getMarkdownParserLimit.tsapps/meteor/client/lib/getPageMeta.spec.tsapps/meteor/client/lib/getMarkdownParserLimit.spec.tsapps/meteor/client/lib/getPageMeta.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts
📚 Learning: 2026-05-11T20:30:35.265Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 40480
File: apps/meteor/client/meteor/startup/accounts.ts:59-61
Timestamp: 2026-05-11T20:30:35.265Z
Learning: In Rocket.Chat’s Meteor client code, when calling `dispatchToastMessage` with `{ type: 'error' }`, pass the raw caught error object as `message` without manual normalization. `dispatchToastMessage` is designed to accept `message: unknown` for error toasts, so avoid converting errors to strings (e.g., `String(error)`) or extracting `error.message` before passing them.
Applied to files:
apps/meteor/client/lib/getMarkdownParserLimit.tsapps/meteor/client/lib/getPageMeta.spec.tsapps/meteor/client/lib/getMarkdownParserLimit.spec.tsapps/meteor/client/lib/getPageMeta.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
apps/meteor/client/lib/getMarkdownParserLimit.tsapps/meteor/client/lib/getPageMeta.spec.tsapps/meteor/client/lib/getMarkdownParserLimit.spec.tsapps/meteor/client/lib/getPageMeta.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
apps/meteor/client/lib/getMarkdownParserLimit.tsapps/meteor/client/lib/getPageMeta.spec.tsapps/meteor/client/lib/getMarkdownParserLimit.spec.tsapps/meteor/client/lib/getPageMeta.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
apps/meteor/client/lib/getMarkdownParserLimit.tsapps/meteor/client/lib/getPageMeta.spec.tsapps/meteor/client/lib/getMarkdownParserLimit.spec.tsapps/meteor/client/lib/getPageMeta.tsapps/meteor/client/views/omnichannel/contactHistory/MessageList/ContactHistoryMessage.tsxapps/meteor/client/lib/normalizeThreadMessage.tsxapps/meteor/client/lib/normalizeThreadMessage.spec.tsxapps/meteor/client/components/MarkdownText.spec.tsxapps/meteor/client/lib/parseMessageTextToAstMarkdown.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.tsapps/meteor/client/components/MarkdownTextInner.tsxapps/meteor/client/components/MarkdownText.tsx
📚 Learning: 2026-02-24T19:22:48.358Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/omnichannel/omnichannel-send-pdf-transcript.spec.ts:66-67
Timestamp: 2026-02-24T19:22:48.358Z
Learning: In Playwright end-to-end tests (e.g., under apps/meteor/tests/e2e/...), prefer locating elements by translated text (getByText) and ARIA roles (getByRole) over data-qa attributes. If translation values change, update the corresponding test locators accordingly. Never use data-qa locators. This guideline applies to all Playwright e2e test specs in the repository and helps keep tests robust to UI text changes and accessible semantics.
Applied to files:
apps/meteor/client/lib/getPageMeta.spec.tsapps/meteor/client/lib/getMarkdownParserLimit.spec.tsapps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts
📚 Learning: 2026-03-06T18:10:15.268Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39397
File: packages/gazzodown/src/code/CodeBlock.spec.tsx:47-68
Timestamp: 2026-03-06T18:10:15.268Z
Learning: In tests (especially those using testing-library/dom/jsdom) for Rocket.Chat components, the HTML <code> element has an implicit ARIA role of 'code'. Therefore, screen.getByRole('code') or screen.findByRole('code') will locate <code> elements even without a role attribute. Do not flag findByRole('code') as invalid in reviews; prefer using the implicit role instead of adding role="code" unless necessary for accessibility.
Applied to files:
apps/meteor/client/lib/getPageMeta.spec.tsapps/meteor/client/lib/getMarkdownParserLimit.spec.tsapps/meteor/client/lib/normalizeThreadMessage.spec.tsxapps/meteor/client/components/MarkdownText.spec.tsxapps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.
Applied to files:
apps/meteor/client/views/omnichannel/contactHistory/MessageList/ContactHistoryMessage.tsxapps/meteor/client/lib/normalizeThreadMessage.tsxapps/meteor/client/lib/normalizeThreadMessage.spec.tsxapps/meteor/client/components/MarkdownText.spec.tsxapps/meteor/client/components/MarkdownTextInner.tsxapps/meteor/client/components/MarkdownText.tsx
🪛 ast-grep (0.44.0)
apps/meteor/client/lib/getPageMeta.spec.ts
[warning] 4-4: Direct modification of innerHTML or outerHTML properties detected. Modifying these properties with unsanitized user input can lead to XSS vulnerabilities. Use safe alternatives or sanitize content first.
Context: document.head.innerHTML = ''
Note: [CWE-79] Improper Neutralization of Input During Web Page Generation
(dom-content-modification)
apps/meteor/client/components/MarkdownTextInner.tsx
[warning] 203-203: Usage of dangerouslySetInnerHTML detected. This bypasses React's built-in XSS protection. Always sanitize HTML content using libraries like DOMPurify before injecting it into the DOM to prevent XSS attacks.
Context: dangerouslySetInnerHTML
Note: [CWE-79] Improper Neutralization of Input During Web Page Generation
(react-unsafe-html-injection)
🔇 Additional comments (7)
apps/meteor/client/lib/getPageMeta.spec.ts (1)
3-38: LGTM!apps/meteor/client/components/MarkdownText.tsx (1)
4-7: LGTM!Also applies to: 19-36
apps/meteor/client/components/MarkdownText.spec.tsx (1)
7-11: LGTM!Also applies to: 507-551
apps/meteor/client/lib/parseMessageTextToAstMarkdown.ts (1)
13-13: LGTM!Also applies to: 133-135
apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts (1)
4-10: LGTM!Also applies to: 557-640
apps/meteor/client/lib/normalizeThreadMessage.tsx (1)
4-23: LGTM!Also applies to: 24-28
apps/meteor/client/lib/normalizeThreadMessage.spec.tsx (1)
1-62: LGTM!Also applies to: 68-76
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 issues found across 12 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/meteor/client/lib/normalizeThreadMessage.spec.tsx">
<violation number="1" location="apps/meteor/client/lib/normalizeThreadMessage.spec.tsx:64">
P1: Test assertion is wrong: `normalizeThreadMessage` returns `<>desc</>` (a React element) for an attachment with `description: 'desc'`, but the test expects `null`. The implementation prioritizes `description` over `title` in attachment rendering, so this input never produces null.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
dionisio-bot
Bot
added
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR is a complementary of #40306. On this PR we are making consistent the behavior between the BE and FE regarding message parsing, with the use of the new
MESSAGE_MAX_PARSE_LENGTHenvironment variable.Issue(s)
CORE-2211
Steps to test or reproduce
Setup: Run Rocket.Chat with the
MESSAGE_MAX_PARSE_LENGTHenvironment variable set to100.Under Limit: Send a message with
< 100characters containing markdown (e.g.,Hello **bold**). Verify the markdown renders correctly. In the database, the message must contain themdproperty.Over Limit: Send a message with
> 100characters containing markdown. Verify it renders as plain text (raw asterisks).Contexts: Verify the same behavior (under vs. over limit) inside a Thread and when Quoting/Replying.
Editing: Edit a short message (currently rendered) and add text to exceed 100 characters. Verify it loses markdown formatting upon saving.
Translations: Enable Auto Translate in a room (Administration > Settings > Message > Auto Translate — requires a translation service configured as per the Auto Translate documentation). Set the target language and send a message in a different language with > 100 characters containing markdown. Verify that the message renders as plain text using the translated text, not the original source language. Also verify the "Translated" indicator is still shown. Repeat inside a Thread parent preview and when Quoting/Replying.
Disabled State: Re-run Rocket.Chat with the
MESSAGE_MAX_PARSE_LENGTHenv var set to0. Verify that every message now render markdown correctly again (0 means disabled).Further comments
Summary by CodeRabbit
Release Notes
New Features
Improvements
Bug Fixes
Tests