Skip to content

refactor(poc): React 19 #40796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tassoevan wants to merge 5 commits into
base: develop
Choose a base branch
from
+15,372 −864
Draft

refactor(poc): React 19 #40796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2b7908
refactor: upgrade `@types/react` and `@types/react-dom`
tassoevan Jun 11, 2026
b8f4347
refactor: upgrade `react` and `react-dom`
tassoevan Jun 12, 2026
089a03d
poc: patch fuselage with react 19
tassoevan Jun 16, 2026
9447dd4
refactor(pdf-worker): upgrade react-pdf
tassoevan Jun 16, 2026
3d8f2a7
test(e2e): wait for lazy room toolbar
tassoevan Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...act-pdf-layout-npm-4.4.2-6c2e3312fa.patch → ...act-pdf-layout-npm-4.6.1-b12fdb71f4.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/lib/index.js b/lib/index.js
index c64bdf2d5f7e704a65be4e9a7116c5ee6a582701..ce6641d0b63daf7c5d3f8a1de773f290c0e9d51c 100644
index b7ea5e30fddb9bdef0034c00f28bbd4f0dee584a..47f7717632bd55d3c42ebb39f1ef5a23c14cfa3a 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -2,8 +2,8 @@ import { upperFirst, capitalize, parseFloat as parseFloat$1, without, pick, comp
Expand All @@ -13,3 +13,12 @@ index c64bdf2d5f7e704a65be4e9a7116c5ee6a582701..ce6641d0b63daf7c5d3f8a1de773f290
import emojiRegex from 'emoji-regex-xs';
import resolveImage from '@react-pdf/image';

@@ -2998,7 +2998,7 @@ const splitPage = (page, pageNumber, fontStore, yoga) => {
const dynamicPage = resolveDynamicPage({ pageNumber }, page, fontStore, yoga);
const height = page.style.height;
const [currentChilds, nextChilds] = splitNodes(wrapArea, contentArea, dynamicPage.children);
- const relayout = (node) =>
+ const relayout = (node) =>
// @ts-expect-error rework pagination
relayoutPage(node, fontStore, yoga);
const currentBox = { ...page.box, height };
929 changes: 929 additions & 0 deletions .yarn/patches/@rocket.chat-fuselage-forms-npm-1.3.0-4bdc8e76d9.patch
View file
Open in desktop

Large diffs are not rendered by default.

363 changes: 363 additions & 0 deletions .yarn/patches/@rocket.chat-fuselage-hooks-npm-0.41.0-d445af7af0.patch
View file
Open in desktop

Large diffs are not rendered by default.

5,528 changes: 5,528 additions & 0 deletions .yarn/patches/@rocket.chat-fuselage-npm-0.79.1-3bebe08c47.patch
View file
Open in desktop

Large diffs are not rendered by default.

513 changes: 513 additions & 0 deletions .yarn/patches/@rocket.chat-fuselage-toastbar-npm-0.35.2-5bb489b0d9.patch
View file
Open in desktop

Large diffs are not rendered by default.

1,248 changes: 1,248 additions & 0 deletions .yarn/patches/@rocket.chat-layout-npm-0.34.3-96f84e7570.patch
View file
Open in desktop

Large diffs are not rendered by default.

180 changes: 180 additions & 0 deletions .yarn/patches/@rocket.chat-logo-npm-0.32.5-c79bfd8935.patch
View file
Open in desktop

Large diffs are not rendered by default.

5,639 changes: 5,639 additions & 0 deletions .yarn/patches/@rocket.chat-onboarding-ui-npm-0.36.2-23fedaef61.patch
View file
Open in desktop

Large diffs are not rendered by default.

139 changes: 139 additions & 0 deletions .yarn/patches/@rocket.chat-styled-npm-0.33.0-aee7eadf8b.patch
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,11 @@ plugins:
spec: "https://raw.githubusercontent.com/devoto13/yarn-plugin-engines/main/bundles/%40yarnpkg/plugin-engines.js"

yarnPath: .yarn/releases/yarn-4.12.0.cjs

packageExtensions: {
"@rocket.chat/fuselage@*": {
dependencies: {
"react-is": "~19.2.7"
},
}
}
4 changes: 2 additions & 2 deletions ...meteor/client/components/ABAC/ABACUpsellModal/__snapshots__/ABACUpsellModal.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`ABACUpsellModal should render the modal with correct content 1`] = `
<body>
<div>
<dialog
aria-labelledby=":r0:-title"
aria-labelledby="_r_0_-title"
aria-modal="true"
class="rcx-box rcx-box--full rcx-modal"
open=""
Expand All @@ -28,7 +28,7 @@ exports[`ABACUpsellModal should render the modal with correct content 1`] = `
</div>
<h2
class="rcx-box rcx-box--full rcx-modal__title"
id=":r0:-title"
id="_r_0_-title"
>
Attribute-Based Access Control
</h2>
Expand Down
44 changes: 22 additions & 22 deletions apps/meteor/client/components/CreateDiscussion/__snapshots__/CreateDiscussion.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
<body>
<div>
<dialog
aria-labelledby=":r0:-title"
aria-labelledby="_r_0_-title"
aria-modal="true"
class="rcx-box rcx-box--full rcx-modal"
open=""
Expand All @@ -23,7 +23,7 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
>
<h2
class="rcx-box rcx-box--full rcx-modal__title"
id=":r0:-title"
id="_r_0_-title"
>
Discussion_title
</h2>
Expand Down Expand Up @@ -63,7 +63,7 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
>
<span
class="rcx-box rcx-box--full rcx-field__label rcx-label"
id="react-aria-:r1:-label"
id="react-aria-_r_1_-label"
>
Parent channel or team
<span
Expand All @@ -86,10 +86,10 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
<input
aria-describedby=""
aria-invalid="false"
aria-labelledby="react-aria-:r1:-label"
aria-labelledby="react-aria-_r_1_-label"
aria-required="true"
class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--undecorated rcx-input-box rcx-css-trljwa rcx-css-rcil7k"
id="react-aria-:r1:"
id="react-aria-_r_1_"
name="parentRoom"
placeholder="Search_options"
value=""
Expand All @@ -113,7 +113,7 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
>
<label
class="rcx-box rcx-box--full rcx-field__label rcx-label"
for="react-aria-:r2:-label"
for="react-aria-_r_2_-label"
>
Name
<span
Expand All @@ -134,7 +134,7 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
aria-invalid="false"
aria-required="true"
class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--undecorated rcx-input-box--type-text rcx-input-box"
id="react-aria-:r2:-label"
id="react-aria-_r_2_-label"
name="name"
size="1"
type="text"
Expand All @@ -158,18 +158,18 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
>
<label
class="rcx-box rcx-box--full rcx-field__label rcx-label"
for="react-aria-:r3:-label"
for="react-aria-_r_3_-label"
>
Topic
</label>
<span
class="rcx-box rcx-box--full rcx-field__row"
>
<input
aria-describedby="react-aria-:r3:-hint"
aria-describedby="react-aria-_r_3_-hint"
aria-invalid="false"
class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--type-text rcx-input-box"
id="react-aria-:r3:-label"
id="react-aria-_r_3_-label"
name="topic"
size="1"
type="text"
Expand All @@ -181,7 +181,7 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
>
<span
class="rcx-box rcx-box--full rcx-field__hint"
id="react-aria-:r3:-hint"
id="react-aria-_r_3_-hint"
>
Displayed_next_to_name
</span>
Expand All @@ -192,7 +192,7 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
>
<span
class="rcx-box rcx-box--full rcx-field__label rcx-label"
id="react-aria-:r4:-label"
id="react-aria-_r_4_-label"
>
Members
</span>
Expand All @@ -209,15 +209,15 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
class="rcx-box rcx-box--full rcx-css-w398ts"
>
<input
aria-controls="react-aria-:r4:-listbox"
aria-controls="react-aria-_r_4_-listbox"
aria-describedby=""
aria-expanded="false"
aria-haspopup="listbox"
aria-invalid="false"
aria-labelledby="react-aria-:r4:-label"
aria-labelledby="react-aria-_r_4_-label"
autocomplete="off"
class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--undecorated rcx-input-box rcx-css-trljwa rcx-css-pqpp8q"
id="react-aria-:r4:"
id="react-aria-_r_4_"
name="usernames"
placeholder="Add_people"
role="combobox"
Expand All @@ -243,27 +243,27 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
>
<label
class="rcx-box rcx-box--full rcx-field__label rcx-label"
for="react-aria-:r5:-label"
for="react-aria-_r_5_-label"
>
Message
</label>
<span
class="rcx-box rcx-box--full rcx-field__row"
>
<textarea
aria-describedby="react-aria-:r5:-hint"
aria-describedby="react-aria-_r_5_-hint"
aria-invalid="false"
class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--type-textarea rcx-input-box"
cols="1"
id="react-aria-:r5:-label"
id="react-aria-_r_5_-label"
name="firstMessage"
rows="5"
size="1"
/>
</span>
<span
class="rcx-box rcx-box--full rcx-field__hint"
id="react-aria-:r5:-hint"
id="react-aria-_r_5_-hint"
>
First_message_hint
</span>
Expand All @@ -288,10 +288,10 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
Encrypted
</div>
<input
aria-describedby="react-aria-:r6:-hint"
aria-describedby="react-aria-_r_6_-hint"
aria-invalid="false"
class="rcx-box rcx-box--full rcx-toggle-switch__input"
id="react-aria-:r6:-label"
id="react-aria-_r_6_-label"
name="encrypted"
type="checkbox"
/>
Expand All @@ -303,7 +303,7 @@ exports[`CreateDiscussion renders Default without crashing 1`] = `
</span>
<span
class="rcx-box rcx-box--full rcx-field__hint"
id="react-aria-:r6:-hint"
id="react-aria-_r_6_-hint"
>
Not_available_for_this_workspace
</span>
Expand Down
4 changes: 2 additions & 2 deletions apps/meteor/client/components/FilterByText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Box, Icon, TextInput, Margins } from '@rocket.chat/fuselage';
import { useAutoFocus, useMergedRefs } from '@rocket.chat/fuselage-hooks';
import type { ChangeEvent, ComponentPropsWithoutRef, FormEvent } from 'react';
import type { ChangeEvent, ComponentPropsWithoutRef, SubmitEvent } from 'react';
import { forwardRef, memo, useCallback } from 'react';
import { useTranslation } from 'react-i18next';

Expand All @@ -18,7 +18,7 @@ const FilterByText = forwardRef<HTMLInputElement, FilterByTextProps>(function Fi
const autoFocusRef = useAutoFocus(shouldAutoFocus);
const mergedRefs = useMergedRefs(ref, autoFocusRef);

const handleFormSubmit = useCallback((event: FormEvent<HTMLFormElement>) => {
const handleFormSubmit = useCallback((event: SubmitEvent<HTMLFormElement>) => {
event.preventDefault();
}, []);

Expand Down
20 changes: 10 additions & 10 deletions ...eteor/client/components/GenericUpsellModal/__snapshots__/GenericUpsellModal.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`GenericUpsellModal renders Default without crashing 1`] = `
<body>
<div>
<dialog
aria-labelledby=":r0:-title"
aria-labelledby="_r_0_-title"
aria-modal="true"
class="rcx-box rcx-box--full rcx-modal"
open=""
Expand All @@ -28,7 +28,7 @@ exports[`GenericUpsellModal renders Default without crashing 1`] = `
</div>
<h2
class="rcx-box rcx-box--full rcx-modal__title"
id=":r0:-title"
id="_r_0_-title"
>
This is the title
</h2>
Expand Down Expand Up @@ -115,7 +115,7 @@ exports[`GenericUpsellModal renders WithAnnotation without crashing 1`] = `
<body>
<div>
<dialog
aria-labelledby=":r1:-title"
aria-labelledby="_r_1_-title"
aria-modal="true"
class="rcx-box rcx-box--full rcx-modal"
open=""
Expand All @@ -139,7 +139,7 @@ exports[`GenericUpsellModal renders WithAnnotation without crashing 1`] = `
</div>
<h2
class="rcx-box rcx-box--full rcx-modal__title"
id=":r1:-title"
id="_r_1_-title"
>
This is the title
</h2>
Expand Down Expand Up @@ -231,7 +231,7 @@ exports[`GenericUpsellModal renders WithCustomButtons without crashing 1`] = `
<body>
<div>
<dialog
aria-labelledby=":r2:-title"
aria-labelledby="_r_2_-title"
aria-modal="true"
class="rcx-box rcx-box--full rcx-modal"
open=""
Expand All @@ -255,7 +255,7 @@ exports[`GenericUpsellModal renders WithCustomButtons without crashing 1`] = `
</div>
<h2
class="rcx-box rcx-box--full rcx-modal__title"
id=":r2:-title"
id="_r_2_-title"
>
This is the title
</h2>
Expand Down Expand Up @@ -342,7 +342,7 @@ exports[`GenericUpsellModal renders WithCustomTagLine without crashing 1`] = `
<body>
<div>
<dialog
aria-labelledby=":r3:-title"
aria-labelledby="_r_3_-title"
aria-modal="true"
class="rcx-box rcx-box--full rcx-modal"
open=""
Expand All @@ -366,7 +366,7 @@ exports[`GenericUpsellModal renders WithCustomTagLine without crashing 1`] = `
</div>
<h2
class="rcx-box rcx-box--full rcx-modal__title"
id=":r3:-title"
id="_r_3_-title"
>
This is the title
</h2>
Expand Down Expand Up @@ -453,7 +453,7 @@ exports[`GenericUpsellModal renders WithFixedWidthAndHeight without crashing 1`]
<body>
<div>
<dialog
aria-labelledby=":r4:-title"
aria-labelledby="_r_4_-title"
aria-modal="true"
class="rcx-box rcx-box--full rcx-modal"
open=""
Expand All @@ -477,7 +477,7 @@ exports[`GenericUpsellModal renders WithFixedWidthAndHeight without crashing 1`]
</div>
<h2
class="rcx-box rcx-box--full rcx-modal__title"
id=":r4:-title"
id="_r_4_-title"
>
This is the title
</h2>
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/client/components/UserAutoCompleteMultiple/UserAutoCompleteMultiple.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const UserAutoCompleteMultiple = forwardRef<HTMLInputElement, UserAutoCompleteMu
onChange={handleOnChange}
filter={filter}
setFilter={setFilter}
renderSelected={({ value: username, onMouseDown }: { value: string; onMouseDown: () => void }) => {
renderSelected={({ value: username, onMouseDown }) => {
const currentCachedOption = selectedCache[username] || {};

return (
Expand Down
16 changes: 8 additions & 8 deletions apps/meteor/client/components/UserInfo/__snapshots__/UserInfo.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,12 @@ exports[`renders Default without crashing 1`] = `
>
<dt
class="rcx-box rcx-box--full rcx-css-1n8o8rn"
id=":r1:"
id="_r_1_"
>
Username
</dt>
<dd
aria-labelledby=":r1:"
aria-labelledby="_r_1_"
class="rcx-box rcx-box--full rcx-css-6hwe8l rcx-css-faoni4"
>
guilherme.gazzo
Expand Down Expand Up @@ -467,12 +467,12 @@ exports[`renders InvitedUser without crashing 1`] = `
>
<dt
class="rcx-box rcx-box--full rcx-css-1n8o8rn"
id=":r3:"
id="_r_3_"
>
Username
</dt>
<dd
aria-labelledby=":r3:"
aria-labelledby="_r_3_"
class="rcx-box rcx-box--full rcx-css-6hwe8l rcx-css-faoni4"
>
guilherme.gazzo
Expand Down Expand Up @@ -778,12 +778,12 @@ exports[`renders WithABACAttributes without crashing 1`] = `
>
<dt
class="rcx-box rcx-box--full rcx-css-1n8o8rn"
id=":r5:"
id="_r_5_"
>
Username
</dt>
<dd
aria-labelledby=":r5:"
aria-labelledby="_r_5_"
class="rcx-box rcx-box--full rcx-css-6hwe8l rcx-css-faoni4"
>
guilherme.gazzo
Expand Down Expand Up @@ -1135,12 +1135,12 @@ exports[`renders WithVoiceCallExtension without crashing 1`] = `
>
<dt
class="rcx-box rcx-box--full rcx-css-1n8o8rn"
id=":r7:"
id="_r_7_"
>
Username
</dt>
<dd
aria-labelledby=":r7:"
aria-labelledby="_r_7_"
class="rcx-box rcx-box--full rcx-css-6hwe8l rcx-css-faoni4"
>
guilherme.gazzo
Expand Down
Loading
Loading