refactor(fuselage-ui-kit): remove unnecessary ReactElement type annotations in components

[tassoevan]

⚠️ This is part 7/23 of #40796. PR for refactor/prepare-types-for-react-19-6 must be merged first.

---

Proposed changes (including videos or screenshots)

As a first step towards upgrading to React 19, it handles types from @types/react looking forward the next major.

Issue(s)

Task: ARCH-2170

Steps to test or reproduce

Further comments

No runtime change is expected from it.

Summary by CodeRabbit

• Refactor
  • Simplified TypeScript typings across the UI kit and surface renderers for cleaner code and better type inference; explicit return-type annotations were removed. No changes to UI behavior or user-facing features.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3350f3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 899027b0-e829-4d05-86a9-92171d09f16c

📥 Commits

Reviewing files that changed from the base of the PR and between dd45311 and 3350f3c.

📒 Files selected for processing (2)

• packages/ui-kit/src/blocks/elements/ButtonElement.ts
• packages/ui-kit/src/blocks/elements/LinearScaleElement.ts

✅ Files skipped from review due to trivial changes (2)

• packages/ui-kit/src/blocks/elements/ButtonElement.ts
• packages/ui-kit/src/blocks/elements/LinearScaleElement.ts

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: 📦 Build Packages
• GitHub Check: cubic · AI code reviewer
• GitHub Check: CodeQL-Build
• GitHub Check: CodeQL-Build

---

Walkthrough

This PR systematically removes explicit ReactElement return type annotations from ~40 React components in the fuselage-ui-kit package, relying on TypeScript's inference. It tightens UiKit.SurfaceRenderer generics to ReactElement<any> and switches some renderer methods to ReactNode. TabElement gets a minor click-handler refactor.

Changes

Type Annotation Simplification

Layer / File(s)	Summary
Core type infrastructure packages/fuselage-ui-kit/src/utils/BlockProps.ts, packages/fuselage-ui-kit/src/surfaces/createSurfaceRenderer.tsx, packages/fuselage-ui-kit/src/utils/UiKitComponent.tsx	BlockProps and createSurfaceRenderer now constrain SurfaceRenderer<ReactElement<any>>. UiKitComponent drops explicit ReactElement | null return type and unused import.
Surface renderer type contracts packages/fuselage-ui-kit/src/surfaces/FuselageSurfaceRenderer.tsx, packages/fuselage-ui-kit/src/surfaces/ContextualBarSurfaceRenderer.tsx, packages/fuselage-ui-kit/src/surfaces/FuselageMessageSurfaceRenderer.tsx	FuselageSurfaceRenderer methods now use ReactElement<any> | null; tab_navigation and video_conf methods change to ReactNode.
Surface wrapper components packages/fuselage-ui-kit/src/surfaces/BannerSurface.tsx, packages/fuselage-ui-kit/src/surfaces/ContextualBarSurface.tsx, packages/fuselage-ui-kit/src/surfaces/MessageSurface.tsx, packages/fuselage-ui-kit/src/surfaces/ModalSurface.tsx, packages/fuselage-ui-kit/src/surfaces/Surface.tsx	Surface wrappers remove explicit ReactElement return type annotations and switch prop typing to ReactNode where appropriate; JSX unchanged.
Block components packages/fuselage-ui-kit/src/blocks/ActionsBlock.Action.tsx, packages/fuselage-ui-kit/src/blocks/ActionsBlock.tsx, packages/fuselage-ui-kit/src/blocks/CalloutBlock.tsx, packages/fuselage-ui-kit/src/blocks/ContextBlock.Item.tsx, packages/fuselage-ui-kit/src/blocks/ContextBlock.tsx, packages/fuselage-ui-kit/src/blocks/DividerBlock.tsx, packages/fuselage-ui-kit/src/blocks/ImageBlock.tsx, packages/fuselage-ui-kit/src/blocks/InfoCard.tsx, packages/fuselage-ui-kit/src/blocks/InputBlock.tsx, packages/fuselage-ui-kit/src/blocks/PreviewBlock.tsx, packages/fuselage-ui-kit/src/blocks/SectionBlock.Fields.tsx, packages/fuselage-ui-kit/src/blocks/SectionBlock.tsx, packages/fuselage-ui-kit/src/blocks/TabNavigationBlock.tsx, packages/fuselage-ui-kit/src/blocks/VideoConferenceBlock/VideoConferenceBlock.tsx	Block components remove explicit ReactElement return types; parser/surfaceRenderer props tightened to SurfaceRenderer<ReactElement<any>>.
Element components packages/fuselage-ui-kit/src/elements/ButtonElement.tsx, packages/fuselage-ui-kit/src/elements/CheckboxElement.tsx, packages/fuselage-ui-kit/src/elements/DatePickerElement.tsx, packages/fuselage-ui-kit/src/elements/IconButtonElement.tsx, packages/fuselage-ui-kit/src/elements/IconElement.tsx, packages/fuselage-ui-kit/src/elements/ImageElement.tsx, packages/fuselage-ui-kit/src/elements/LinearScaleElement.tsx, packages/fuselage-ui-kit/src/elements/MultiStaticSelectElement.tsx, packages/fuselage-ui-kit/src/elements/OverflowElement.tsx, packages/fuselage-ui-kit/src/elements/PlainTextInputElement.tsx, packages/fuselage-ui-kit/src/elements/RadioButtonElement.tsx, packages/fuselage-ui-kit/src/elements/StaticSelectElement.tsx, packages/fuselage-ui-kit/src/elements/TabElement.tsx, packages/fuselage-ui-kit/src/elements/TimePickerElement.tsx, packages/fuselage-ui-kit/src/elements/ToggleSwitchElement.tsx, packages/fuselage-ui-kit/src/elements/UsersSelectElement/MultiUsersSelectElement.tsx	Element components remove explicit ReactElement return types and simplify React type imports. TabElement click handler simplified to early-return when disabled, then call select and action.
ui-kit type TODOs packages/ui-kit/src/blocks/elements/ButtonElement.ts, packages/ui-kit/src/blocks/elements/LinearScaleElement.ts	Added inline TODO comments about url validation for ButtonElement and maxValue reasonable limits for LinearScaleElement; no type signature changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

type: chore

Suggested reviewers

• ggazzo
• dougfabris

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main refactoring effort across the changeset: removing unnecessary ReactElement type annotations from components throughout the fuselage-ui-kit package.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (2)

• REACT-19: Request failed with status code 401
• ARCH-2170: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

❌ Patch coverage is 58.33333% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.03%. Comparing base (67a7d1b) to head (3350f3c).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #40809      +/-   ##
===========================================
- Coverage    70.09%   70.03%   -0.06%     
===========================================
  Files         3337     3337              
  Lines       123506   123509       +3     
  Branches     22046    22020      -26     
===========================================
- Hits         86568    86497      -71     
- Misses       33602    33656      +54     
- Partials      3336     3356      +20     

Flag	Coverage Δ
e2e	59.37% <ø> (-0.07%)	⬇️
e2e-api	46.24% <ø> (-0.88%)	⬇️
unit	70.81% <58.33%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cubic-dev-ai]

No issues found across 41 files

_{Re-trigger cubic}

[hacktron-app]

2 issues found across 2 files

Severity	Count
	1
	1

View full scan results