refactor: remove unnecessary ReactElement type annotations in components#40820
Merged
Conversation
Contributor
WalkthroughThis PR removes explicit ChangesReact typing cleanup across client views
Sequence Diagram(s)Estimated review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
|
|
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #40820 +/- ##
===========================================
- Coverage 70.18% 70.15% -0.04%
===========================================
Files 3342 3341 -1
Lines 123685 123656 -29
Branches 22092 22077 -15
===========================================
- Hits 86813 86747 -66
- Misses 33534 33558 +24
- Partials 3338 3351 +13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
tassoevan
force-pushed
the
refactor/prepare-types-for-react-19-18
branch
from
1cb0582 to
1e54282
Compare
- Removed ReactElement type annotations from various components to simplify type definitions. - Updated components such as AutoCompleteDepartmentAgent, AutoCompleteOutboundProvider, RecipientSelect, and others to use implicit return types. - Improved code readability and maintainability by streamlining type imports and component definitions.
tassoevan
force-pushed
the
refactor/prepare-types-for-react-19-18
branch
from
1e54282 to
88890c2
Compare
tassoevan
added
the
stat: QA assured
dionisio-bot
Bot
removed
the
stat: QA assured
tassoevan
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
ggazzo
approved these changes
Jun 9, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/meteor/client/views/marketplace/AppsPage/UnsupportedEmptyState.tsx (1)
8-26:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winBehavioral change inconsistent with PR objectives.
This component introduces permission-based conditional rendering (
isAdmincheck on line 9) that changes the displayed title, description, and optionally showsUpdateRocketChatButton(line 25). While the review stack context mentions "with one permission-based empty-state branch update," the PR objectives explicitly state "No runtime behavior changes are expected."The logic appears functionally correct, but this behavioral change should be acknowledged in the PR description or split into a separate commit/PR for clarity.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/meteor/client/views/marketplace/AppsPage/UnsupportedEmptyState.tsx` around lines 8 - 26, The new permission-based behavior in UnsupportedEmptyState (usePermission/isAdmin, conditional title/description and conditional <UpdateRocketChatButton />) changed runtime behavior; revert this by removing usePermission and the isAdmin branching: set title and description to the original static marketplace strings (e.g., t('Marketplace_unavailable') and t('Marketplace_unavailable_description')) and remove the conditional rendering of <UpdateRocketChatButton /> so the component's output remains unchanged; if you need the admin-specific branch, introduce it in a separate commit/PR.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/meteor/client/views/navigation/sidebar/hooks/useShortcutOpenMenu.ts`:
- Around line 6-9: The hook useShortcutOpenMenu currently calls
tinykeys(ref.current...) unconditionally which can throw when ref.current is
null; guard by checking that ref.current is non-null before invoking tinykeys
(e.g., if (!ref.current) return/skip), assign the unsubscribe only inside that
guarded branch, and in the useEffect cleanup check/unsubscribe only if
unsubscribe was created (or return a noop) so no attempt is made to call an
undefined unsubscribe; reference useShortcutOpenMenu, ref.current and tinykeys
when locating the call to change.
---
Outside diff comments:
In `@apps/meteor/client/views/marketplace/AppsPage/UnsupportedEmptyState.tsx`:
- Around line 8-26: The new permission-based behavior in UnsupportedEmptyState
(usePermission/isAdmin, conditional title/description and conditional
<UpdateRocketChatButton />) changed runtime behavior; revert this by removing
usePermission and the isAdmin branching: set title and description to the
original static marketplace strings (e.g., t('Marketplace_unavailable') and
t('Marketplace_unavailable_description')) and remove the conditional rendering
of <UpdateRocketChatButton /> so the component's output remains unchanged; if
you need the admin-specific branch, introduce it in a separate commit/PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e125990c-19dc-4565-8303-13b864dcc838
📒 Files selected for processing (121)
apps/meteor/client/views/directory/DirectoryPage.tsxapps/meteor/client/views/directory/tabs/channels/ChannelsTab.tsxapps/meteor/client/views/directory/tabs/teams/TeamsTab.tsxapps/meteor/client/views/directory/tabs/users/UsersTab.tsxapps/meteor/client/views/directory/tabs/users/UsersTable/UsersTable.tsxapps/meteor/client/views/e2e/SaveE2EPasswordModal.tsxapps/meteor/client/views/home/CustomHomePage.tsxapps/meteor/client/views/home/CustomHomePageContent.tsxapps/meteor/client/views/home/DefaultHomePage.tsxapps/meteor/client/views/home/HomePage.tsxapps/meteor/client/views/home/HomePageHeader.tsxapps/meteor/client/views/home/HomepageGridItem.tsxapps/meteor/client/views/home/cards/AddUsersCard.tsxapps/meteor/client/views/home/cards/CreateChannelsCard.tsxapps/meteor/client/views/home/cards/CustomContentCard.tsxapps/meteor/client/views/home/cards/DesktopAppsCard.tsxapps/meteor/client/views/home/cards/DocumentationCard.tsxapps/meteor/client/views/home/cards/JoinRoomsCard.tsxapps/meteor/client/views/home/cards/MobileAppsCard.tsxapps/meteor/client/views/invite/InvitePage.tsxapps/meteor/client/views/invite/SecretURLPage.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPage.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPageHeader.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPageTabs.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppInstances/AppInstances.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/AppLogs.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppReleases/AppReleases.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppReleases/AppReleasesItem.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequestItem.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequests.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequestsLoading.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSecurity/AppSecurity.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSecurity/AppSecurityLabel.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSettings/AppSetting.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsxapps/meteor/client/views/marketplace/AppsList/AppRow.tsxapps/meteor/client/views/marketplace/AppsList/AppsList.tsxapps/meteor/client/views/marketplace/AppsPage/AppsFilters.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPage.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPageConnectionError.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPageContentSkeleton.tsxapps/meteor/client/views/marketplace/AppsPage/FeaturedAppsSections.tsxapps/meteor/client/views/marketplace/AppsPage/NoInstalledAppMatchesEmptyState.tsxapps/meteor/client/views/marketplace/AppsPage/NoInstalledAppsEmptyState.tsxapps/meteor/client/views/marketplace/AppsPage/NoMarketplaceOrInstalledAppMatchesEmptyState.tsxapps/meteor/client/views/marketplace/AppsPage/UnsupportedEmptyState.tsxapps/meteor/client/views/marketplace/AppsRoute.tsxapps/meteor/client/views/marketplace/BundleChips.tsxapps/meteor/client/views/marketplace/MarketplaceRouter.tsxapps/meteor/client/views/marketplace/MarketplaceSidebar.tsxapps/meteor/client/views/marketplace/components/AppPermissionsList.tsxapps/meteor/client/views/marketplace/components/BannerEnterpriseTrialEnded.tsxapps/meteor/client/views/marketplace/components/CategoryFilter/CategoryDropDown.tsxapps/meteor/client/views/marketplace/components/CategoryFilter/CategoryDropDownList.tsxapps/meteor/client/views/marketplace/components/EnabledAppsCount.tsxapps/meteor/client/views/marketplace/components/MarketplaceHeader.tsxapps/meteor/client/views/marketplace/components/RadioButtonList.tsxapps/meteor/client/views/marketplace/components/RadioDropDown/RadioDropDown.tsxapps/meteor/client/views/marketplace/components/ScreenshotCarousel.tsxapps/meteor/client/views/marketplace/components/ScreenshotCarouselAnchor.tsxapps/meteor/client/views/marketplace/helpers/isValidReference.tsxapps/meteor/client/views/modal/uikit/ModalBlock.tsxapps/meteor/client/views/navigation/sidebar/RoomList/SidebarItem.tsxapps/meteor/client/views/navigation/sidebar/hooks/usePreventDefault.tsapps/meteor/client/views/navigation/sidebar/hooks/useShortcutOpenMenu.tsapps/meteor/client/views/navigation/sidepanel/SidepanelItem/SidepanelItem.tsxapps/meteor/client/views/notAuthorized/NotAuthorizedPage.tsxapps/meteor/client/views/notFound/NotFoundPage.tsxapps/meteor/client/views/omnichannel/OmnichannelRouter.tsxapps/meteor/client/views/omnichannel/additionalForms/AutoCompleteUnits.tsxapps/meteor/client/views/omnichannel/agents/AgentEditWithData.tsxapps/meteor/client/views/omnichannel/agents/AgentsPage.tsxapps/meteor/client/views/omnichannel/agents/AgentsTable/AgentsTableRow.tsxapps/meteor/client/views/omnichannel/analytics/InterchangeableChart.tsxapps/meteor/client/views/omnichannel/cannedResponses/components/CannedResponsesComposer/InsertPlaceholderDropdown.tsxapps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/CannedResponseList.tsxapps/meteor/client/views/omnichannel/components/AgentInfoDetails.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteAgent.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteContact/AutoCompleteContact.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteDepartment.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteMonitors.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteMultipleAgent.tsxapps/meteor/client/views/omnichannel/components/RoomActivityIcon.tsxapps/meteor/client/views/omnichannel/components/Tags.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/AutoCompleteDepartmentAgent.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/AutoCompleteOutboundProvider.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/RecipientSelect.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/modals/OutboundMessageModal/OutboundMessageCloseConfirmationModal.tsxapps/meteor/client/views/omnichannel/contactInfo/EditContactInfo.tsxapps/meteor/client/views/omnichannel/departments/DepartmentsTable/DepartmentItemMenu.tsxapps/meteor/client/views/omnichannel/departments/DepartmentsTable/RemoveDepartmentModal.tsxapps/meteor/client/views/omnichannel/directory/chats/Chat.tsxapps/meteor/client/views/omnichannel/directory/chats/ChatsTable/ChatsTableFilter.tsxapps/meteor/client/views/omnichannel/directory/contacts/ContactItemMenu.tsxapps/meteor/client/views/omnichannel/directory/contacts/RemoveContactModal.tsxapps/meteor/client/views/omnichannel/directory/contexts/ChatsContext.tsapps/meteor/client/views/omnichannel/installation/Installation.tsxapps/meteor/client/views/omnichannel/managers/AddManager.tsxapps/meteor/client/views/omnichannel/managers/ManagersRoute.tsxapps/meteor/client/views/omnichannel/managers/RemoveManagerButton.tsxapps/meteor/client/views/omnichannel/modals/EnterpriseDepartmentsModal.tsxapps/meteor/client/views/omnichannel/modals/ForwardChatModal.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesPage.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesResetModal.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesRoute.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesTable.tsxapps/meteor/client/views/omnichannel/priorities/PriorityEditForm.tsxapps/meteor/client/views/omnichannel/priorities/PriorityEditFormWithData.tsxapps/meteor/client/views/omnichannel/priorities/PriorityIcon.tsxapps/meteor/client/views/omnichannel/priorities/PriorityList.tsxapps/meteor/client/views/omnichannel/queueList/QueueListTable.tsxapps/meteor/client/views/omnichannel/realTimeMonitoring/counter/CounterItem.tsxapps/meteor/client/views/omnichannel/reports/components/BarChart.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCard.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCardContent.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCardErrorState.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaEdit.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaEditWithData.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaNew.tsxapps/meteor/client/views/outlookCalendar/OutlookEventsList/OutlookEventsList.tsxapps/meteor/client/views/outlookCalendar/OutlookSettingsList/OutlookSettingsList.tsx
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Hacktron Security Check
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/views/home/cards/AddUsersCard.tsxapps/meteor/client/views/invite/InvitePage.tsxapps/meteor/client/views/home/cards/DocumentationCard.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPageHeader.tsxapps/meteor/client/views/home/CustomHomePage.tsxapps/meteor/client/views/home/cards/JoinRoomsCard.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSecurity/AppSecurityLabel.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteMultipleAgent.tsxapps/meteor/client/views/home/HomePageHeader.tsxapps/meteor/client/views/omnichannel/directory/chats/ChatsTable/ChatsTableFilter.tsxapps/meteor/client/views/home/HomepageGridItem.tsxapps/meteor/client/views/home/DefaultHomePage.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteMonitors.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSecurity/AppSecurity.tsxapps/meteor/client/views/omnichannel/components/AgentInfoDetails.tsxapps/meteor/client/views/invite/SecretURLPage.tsxapps/meteor/client/views/marketplace/components/CategoryFilter/CategoryDropDown.tsxapps/meteor/client/views/e2e/SaveE2EPasswordModal.tsxapps/meteor/client/views/navigation/sidebar/hooks/usePreventDefault.tsapps/meteor/client/views/marketplace/AppsPage/NoInstalledAppsEmptyState.tsxapps/meteor/client/views/home/CustomHomePageContent.tsxapps/meteor/client/views/omnichannel/agents/AgentsPage.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/modals/OutboundMessageModal/OutboundMessageCloseConfirmationModal.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaNew.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCardContent.tsxapps/meteor/client/views/omnichannel/analytics/InterchangeableChart.tsxapps/meteor/client/views/omnichannel/priorities/PriorityIcon.tsxapps/meteor/client/views/omnichannel/managers/ManagersRoute.tsxapps/meteor/client/views/marketplace/components/RadioButtonList.tsxapps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/CannedResponseList.tsxapps/meteor/client/views/notFound/NotFoundPage.tsxapps/meteor/client/views/home/cards/DesktopAppsCard.tsxapps/meteor/client/views/omnichannel/directory/chats/Chat.tsxapps/meteor/client/views/omnichannel/additionalForms/AutoCompleteUnits.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/AutoCompleteOutboundProvider.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesResetModal.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/RecipientSelect.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPageContentSkeleton.tsxapps/meteor/client/views/marketplace/AppsPage/UnsupportedEmptyState.tsxapps/meteor/client/views/omnichannel/installation/Installation.tsxapps/meteor/client/views/marketplace/AppsList/AppsList.tsxapps/meteor/client/views/omnichannel/reports/components/BarChart.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppReleases/AppReleases.tsxapps/meteor/client/views/navigation/sidebar/hooks/useShortcutOpenMenu.tsapps/meteor/client/views/home/cards/MobileAppsCard.tsxapps/meteor/client/views/navigation/sidebar/RoomList/SidebarItem.tsxapps/meteor/client/views/omnichannel/cannedResponses/components/CannedResponsesComposer/InsertPlaceholderDropdown.tsxapps/meteor/client/views/home/HomePage.tsxapps/meteor/client/views/omnichannel/priorities/PriorityEditFormWithData.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteDepartment.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCardErrorState.tsxapps/meteor/client/views/marketplace/components/MarketplaceHeader.tsxapps/meteor/client/views/home/cards/CustomContentCard.tsxapps/meteor/client/views/omnichannel/realTimeMonitoring/counter/CounterItem.tsxapps/meteor/client/views/marketplace/helpers/isValidReference.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPage.tsxapps/meteor/client/views/marketplace/components/BannerEnterpriseTrialEnded.tsxapps/meteor/client/views/omnichannel/components/RoomActivityIcon.tsxapps/meteor/client/views/omnichannel/directory/contacts/ContactItemMenu.tsxapps/meteor/client/views/directory/tabs/teams/TeamsTab.tsxapps/meteor/client/views/omnichannel/directory/contexts/ChatsContext.tsapps/meteor/client/views/omnichannel/managers/AddManager.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequestsLoading.tsxapps/meteor/client/views/marketplace/AppsPage/AppsFilters.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPageConnectionError.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteAgent.tsxapps/meteor/client/views/marketplace/AppsList/AppRow.tsxapps/meteor/client/views/home/cards/CreateChannelsCard.tsxapps/meteor/client/views/omnichannel/OmnichannelRouter.tsxapps/meteor/client/views/omnichannel/agents/AgentEditWithData.tsxapps/meteor/client/views/modal/uikit/ModalBlock.tsxapps/meteor/client/views/omnichannel/contactInfo/EditContactInfo.tsxapps/meteor/client/views/omnichannel/managers/RemoveManagerButton.tsxapps/meteor/client/views/omnichannel/agents/AgentsTable/AgentsTableRow.tsxapps/meteor/client/views/marketplace/MarketplaceRouter.tsxapps/meteor/client/views/marketplace/components/RadioDropDown/RadioDropDown.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSettings/AppSetting.tsxapps/meteor/client/views/notAuthorized/NotAuthorizedPage.tsxapps/meteor/client/views/marketplace/components/ScreenshotCarousel.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequests.tsxapps/meteor/client/views/omnichannel/queueList/QueueListTable.tsxapps/meteor/client/views/marketplace/AppsPage/FeaturedAppsSections.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/AppLogs.tsxapps/meteor/client/views/navigation/sidepanel/SidepanelItem/SidepanelItem.tsxapps/meteor/client/views/directory/DirectoryPage.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCard.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsxapps/meteor/client/views/omnichannel/priorities/PriorityEditForm.tsxapps/meteor/client/views/omnichannel/directory/contacts/RemoveContactModal.tsxapps/meteor/client/views/marketplace/components/AppPermissionsList.tsxapps/meteor/client/views/directory/tabs/channels/ChannelsTab.tsxapps/meteor/client/views/outlookCalendar/OutlookEventsList/OutlookEventsList.tsxapps/meteor/client/views/omnichannel/departments/DepartmentsTable/RemoveDepartmentModal.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesRoute.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/AutoCompleteDepartmentAgent.tsxapps/meteor/client/views/omnichannel/components/Tags.tsxapps/meteor/client/views/directory/tabs/users/UsersTable/UsersTable.tsxapps/meteor/client/views/marketplace/components/ScreenshotCarouselAnchor.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPageTabs.tsxapps/meteor/client/views/marketplace/components/CategoryFilter/CategoryDropDownList.tsxapps/meteor/client/views/marketplace/BundleChips.tsxapps/meteor/client/views/marketplace/components/EnabledAppsCount.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequestItem.tsxapps/meteor/client/views/marketplace/AppsPage/NoInstalledAppMatchesEmptyState.tsxapps/meteor/client/views/omnichannel/departments/DepartmentsTable/DepartmentItemMenu.tsxapps/meteor/client/views/marketplace/AppsPage/NoMarketplaceOrInstalledAppMatchesEmptyState.tsxapps/meteor/client/views/marketplace/MarketplaceSidebar.tsxapps/meteor/client/views/directory/tabs/users/UsersTab.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppReleases/AppReleasesItem.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesTable.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppInstances/AppInstances.tsxapps/meteor/client/views/marketplace/AppsRoute.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPage.tsxapps/meteor/client/views/omnichannel/priorities/PriorityList.tsxapps/meteor/client/views/outlookCalendar/OutlookSettingsList/OutlookSettingsList.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteContact/AutoCompleteContact.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesPage.tsxapps/meteor/client/views/omnichannel/modals/ForwardChatModal.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaEdit.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaEditWithData.tsxapps/meteor/client/views/omnichannel/modals/EnterpriseDepartmentsModal.tsx
🧠 Learnings (6)
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.
Applied to files:
apps/meteor/client/views/home/cards/AddUsersCard.tsxapps/meteor/client/views/invite/InvitePage.tsxapps/meteor/client/views/home/cards/DocumentationCard.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPageHeader.tsxapps/meteor/client/views/home/CustomHomePage.tsxapps/meteor/client/views/home/cards/JoinRoomsCard.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSecurity/AppSecurityLabel.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteMultipleAgent.tsxapps/meteor/client/views/home/HomePageHeader.tsxapps/meteor/client/views/omnichannel/directory/chats/ChatsTable/ChatsTableFilter.tsxapps/meteor/client/views/home/HomepageGridItem.tsxapps/meteor/client/views/home/DefaultHomePage.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteMonitors.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSecurity/AppSecurity.tsxapps/meteor/client/views/omnichannel/components/AgentInfoDetails.tsxapps/meteor/client/views/invite/SecretURLPage.tsxapps/meteor/client/views/marketplace/components/CategoryFilter/CategoryDropDown.tsxapps/meteor/client/views/e2e/SaveE2EPasswordModal.tsxapps/meteor/client/views/marketplace/AppsPage/NoInstalledAppsEmptyState.tsxapps/meteor/client/views/home/CustomHomePageContent.tsxapps/meteor/client/views/omnichannel/agents/AgentsPage.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/modals/OutboundMessageModal/OutboundMessageCloseConfirmationModal.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaNew.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCardContent.tsxapps/meteor/client/views/omnichannel/analytics/InterchangeableChart.tsxapps/meteor/client/views/omnichannel/priorities/PriorityIcon.tsxapps/meteor/client/views/omnichannel/managers/ManagersRoute.tsxapps/meteor/client/views/marketplace/components/RadioButtonList.tsxapps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/CannedResponseList.tsxapps/meteor/client/views/notFound/NotFoundPage.tsxapps/meteor/client/views/home/cards/DesktopAppsCard.tsxapps/meteor/client/views/omnichannel/directory/chats/Chat.tsxapps/meteor/client/views/omnichannel/additionalForms/AutoCompleteUnits.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/AutoCompleteOutboundProvider.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesResetModal.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/RecipientSelect.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPageContentSkeleton.tsxapps/meteor/client/views/marketplace/AppsPage/UnsupportedEmptyState.tsxapps/meteor/client/views/omnichannel/installation/Installation.tsxapps/meteor/client/views/marketplace/AppsList/AppsList.tsxapps/meteor/client/views/omnichannel/reports/components/BarChart.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppReleases/AppReleases.tsxapps/meteor/client/views/home/cards/MobileAppsCard.tsxapps/meteor/client/views/navigation/sidebar/RoomList/SidebarItem.tsxapps/meteor/client/views/omnichannel/cannedResponses/components/CannedResponsesComposer/InsertPlaceholderDropdown.tsxapps/meteor/client/views/home/HomePage.tsxapps/meteor/client/views/omnichannel/priorities/PriorityEditFormWithData.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteDepartment.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCardErrorState.tsxapps/meteor/client/views/marketplace/components/MarketplaceHeader.tsxapps/meteor/client/views/home/cards/CustomContentCard.tsxapps/meteor/client/views/omnichannel/realTimeMonitoring/counter/CounterItem.tsxapps/meteor/client/views/marketplace/helpers/isValidReference.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPage.tsxapps/meteor/client/views/marketplace/components/BannerEnterpriseTrialEnded.tsxapps/meteor/client/views/omnichannel/components/RoomActivityIcon.tsxapps/meteor/client/views/omnichannel/directory/contacts/ContactItemMenu.tsxapps/meteor/client/views/directory/tabs/teams/TeamsTab.tsxapps/meteor/client/views/omnichannel/managers/AddManager.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequestsLoading.tsxapps/meteor/client/views/marketplace/AppsPage/AppsFilters.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPageConnectionError.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteAgent.tsxapps/meteor/client/views/marketplace/AppsList/AppRow.tsxapps/meteor/client/views/home/cards/CreateChannelsCard.tsxapps/meteor/client/views/omnichannel/OmnichannelRouter.tsxapps/meteor/client/views/omnichannel/agents/AgentEditWithData.tsxapps/meteor/client/views/modal/uikit/ModalBlock.tsxapps/meteor/client/views/omnichannel/contactInfo/EditContactInfo.tsxapps/meteor/client/views/omnichannel/managers/RemoveManagerButton.tsxapps/meteor/client/views/omnichannel/agents/AgentsTable/AgentsTableRow.tsxapps/meteor/client/views/marketplace/MarketplaceRouter.tsxapps/meteor/client/views/marketplace/components/RadioDropDown/RadioDropDown.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSettings/AppSetting.tsxapps/meteor/client/views/notAuthorized/NotAuthorizedPage.tsxapps/meteor/client/views/marketplace/components/ScreenshotCarousel.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequests.tsxapps/meteor/client/views/omnichannel/queueList/QueueListTable.tsxapps/meteor/client/views/marketplace/AppsPage/FeaturedAppsSections.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/AppLogs.tsxapps/meteor/client/views/navigation/sidepanel/SidepanelItem/SidepanelItem.tsxapps/meteor/client/views/directory/DirectoryPage.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCard.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsxapps/meteor/client/views/omnichannel/priorities/PriorityEditForm.tsxapps/meteor/client/views/omnichannel/directory/contacts/RemoveContactModal.tsxapps/meteor/client/views/marketplace/components/AppPermissionsList.tsxapps/meteor/client/views/directory/tabs/channels/ChannelsTab.tsxapps/meteor/client/views/outlookCalendar/OutlookEventsList/OutlookEventsList.tsxapps/meteor/client/views/omnichannel/departments/DepartmentsTable/RemoveDepartmentModal.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesRoute.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/AutoCompleteDepartmentAgent.tsxapps/meteor/client/views/omnichannel/components/Tags.tsxapps/meteor/client/views/directory/tabs/users/UsersTable/UsersTable.tsxapps/meteor/client/views/marketplace/components/ScreenshotCarouselAnchor.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPageTabs.tsxapps/meteor/client/views/marketplace/components/CategoryFilter/CategoryDropDownList.tsxapps/meteor/client/views/marketplace/BundleChips.tsxapps/meteor/client/views/marketplace/components/EnabledAppsCount.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequestItem.tsxapps/meteor/client/views/marketplace/AppsPage/NoInstalledAppMatchesEmptyState.tsxapps/meteor/client/views/omnichannel/departments/DepartmentsTable/DepartmentItemMenu.tsxapps/meteor/client/views/marketplace/AppsPage/NoMarketplaceOrInstalledAppMatchesEmptyState.tsxapps/meteor/client/views/marketplace/MarketplaceSidebar.tsxapps/meteor/client/views/directory/tabs/users/UsersTab.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppReleases/AppReleasesItem.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesTable.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppInstances/AppInstances.tsxapps/meteor/client/views/marketplace/AppsRoute.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPage.tsxapps/meteor/client/views/omnichannel/priorities/PriorityList.tsxapps/meteor/client/views/outlookCalendar/OutlookSettingsList/OutlookSettingsList.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteContact/AutoCompleteContact.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesPage.tsxapps/meteor/client/views/omnichannel/modals/ForwardChatModal.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaEdit.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaEditWithData.tsxapps/meteor/client/views/omnichannel/modals/EnterpriseDepartmentsModal.tsx
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
apps/meteor/client/views/home/cards/AddUsersCard.tsxapps/meteor/client/views/invite/InvitePage.tsxapps/meteor/client/views/home/cards/DocumentationCard.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPageHeader.tsxapps/meteor/client/views/home/CustomHomePage.tsxapps/meteor/client/views/home/cards/JoinRoomsCard.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSecurity/AppSecurityLabel.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteMultipleAgent.tsxapps/meteor/client/views/home/HomePageHeader.tsxapps/meteor/client/views/omnichannel/directory/chats/ChatsTable/ChatsTableFilter.tsxapps/meteor/client/views/home/HomepageGridItem.tsxapps/meteor/client/views/home/DefaultHomePage.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteMonitors.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSecurity/AppSecurity.tsxapps/meteor/client/views/omnichannel/components/AgentInfoDetails.tsxapps/meteor/client/views/invite/SecretURLPage.tsxapps/meteor/client/views/marketplace/components/CategoryFilter/CategoryDropDown.tsxapps/meteor/client/views/e2e/SaveE2EPasswordModal.tsxapps/meteor/client/views/navigation/sidebar/hooks/usePreventDefault.tsapps/meteor/client/views/marketplace/AppsPage/NoInstalledAppsEmptyState.tsxapps/meteor/client/views/home/CustomHomePageContent.tsxapps/meteor/client/views/omnichannel/agents/AgentsPage.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/modals/OutboundMessageModal/OutboundMessageCloseConfirmationModal.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaNew.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCardContent.tsxapps/meteor/client/views/omnichannel/analytics/InterchangeableChart.tsxapps/meteor/client/views/omnichannel/priorities/PriorityIcon.tsxapps/meteor/client/views/omnichannel/managers/ManagersRoute.tsxapps/meteor/client/views/marketplace/components/RadioButtonList.tsxapps/meteor/client/views/omnichannel/cannedResponses/contextualBar/CannedResponse/CannedResponseList.tsxapps/meteor/client/views/notFound/NotFoundPage.tsxapps/meteor/client/views/home/cards/DesktopAppsCard.tsxapps/meteor/client/views/omnichannel/directory/chats/Chat.tsxapps/meteor/client/views/omnichannel/additionalForms/AutoCompleteUnits.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/AutoCompleteOutboundProvider.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesResetModal.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/RecipientSelect.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPageContentSkeleton.tsxapps/meteor/client/views/marketplace/AppsPage/UnsupportedEmptyState.tsxapps/meteor/client/views/omnichannel/installation/Installation.tsxapps/meteor/client/views/marketplace/AppsList/AppsList.tsxapps/meteor/client/views/omnichannel/reports/components/BarChart.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppReleases/AppReleases.tsxapps/meteor/client/views/navigation/sidebar/hooks/useShortcutOpenMenu.tsapps/meteor/client/views/home/cards/MobileAppsCard.tsxapps/meteor/client/views/navigation/sidebar/RoomList/SidebarItem.tsxapps/meteor/client/views/omnichannel/cannedResponses/components/CannedResponsesComposer/InsertPlaceholderDropdown.tsxapps/meteor/client/views/home/HomePage.tsxapps/meteor/client/views/omnichannel/priorities/PriorityEditFormWithData.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteDepartment.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCardErrorState.tsxapps/meteor/client/views/marketplace/components/MarketplaceHeader.tsxapps/meteor/client/views/home/cards/CustomContentCard.tsxapps/meteor/client/views/omnichannel/realTimeMonitoring/counter/CounterItem.tsxapps/meteor/client/views/marketplace/helpers/isValidReference.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPage.tsxapps/meteor/client/views/marketplace/components/BannerEnterpriseTrialEnded.tsxapps/meteor/client/views/omnichannel/components/RoomActivityIcon.tsxapps/meteor/client/views/omnichannel/directory/contacts/ContactItemMenu.tsxapps/meteor/client/views/directory/tabs/teams/TeamsTab.tsxapps/meteor/client/views/omnichannel/directory/contexts/ChatsContext.tsapps/meteor/client/views/omnichannel/managers/AddManager.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequestsLoading.tsxapps/meteor/client/views/marketplace/AppsPage/AppsFilters.tsxapps/meteor/client/views/marketplace/AppsPage/AppsPageConnectionError.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteAgent.tsxapps/meteor/client/views/marketplace/AppsList/AppRow.tsxapps/meteor/client/views/home/cards/CreateChannelsCard.tsxapps/meteor/client/views/omnichannel/OmnichannelRouter.tsxapps/meteor/client/views/omnichannel/agents/AgentEditWithData.tsxapps/meteor/client/views/modal/uikit/ModalBlock.tsxapps/meteor/client/views/omnichannel/contactInfo/EditContactInfo.tsxapps/meteor/client/views/omnichannel/managers/RemoveManagerButton.tsxapps/meteor/client/views/omnichannel/agents/AgentsTable/AgentsTableRow.tsxapps/meteor/client/views/marketplace/MarketplaceRouter.tsxapps/meteor/client/views/marketplace/components/RadioDropDown/RadioDropDown.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSettings/AppSetting.tsxapps/meteor/client/views/notAuthorized/NotAuthorizedPage.tsxapps/meteor/client/views/marketplace/components/ScreenshotCarousel.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequests.tsxapps/meteor/client/views/omnichannel/queueList/QueueListTable.tsxapps/meteor/client/views/marketplace/AppsPage/FeaturedAppsSections.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/AppLogs.tsxapps/meteor/client/views/navigation/sidepanel/SidepanelItem/SidepanelItem.tsxapps/meteor/client/views/directory/DirectoryPage.tsxapps/meteor/client/views/omnichannel/reports/components/ReportCard.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsxapps/meteor/client/views/omnichannel/priorities/PriorityEditForm.tsxapps/meteor/client/views/omnichannel/directory/contacts/RemoveContactModal.tsxapps/meteor/client/views/marketplace/components/AppPermissionsList.tsxapps/meteor/client/views/directory/tabs/channels/ChannelsTab.tsxapps/meteor/client/views/outlookCalendar/OutlookEventsList/OutlookEventsList.tsxapps/meteor/client/views/omnichannel/departments/DepartmentsTable/RemoveDepartmentModal.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesRoute.tsxapps/meteor/client/views/omnichannel/components/outboundMessage/components/AutoCompleteDepartmentAgent.tsxapps/meteor/client/views/omnichannel/components/Tags.tsxapps/meteor/client/views/directory/tabs/users/UsersTable/UsersTable.tsxapps/meteor/client/views/marketplace/components/ScreenshotCarouselAnchor.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPageTabs.tsxapps/meteor/client/views/marketplace/components/CategoryFilter/CategoryDropDownList.tsxapps/meteor/client/views/marketplace/BundleChips.tsxapps/meteor/client/views/marketplace/components/EnabledAppsCount.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppRequests/AppRequestItem.tsxapps/meteor/client/views/marketplace/AppsPage/NoInstalledAppMatchesEmptyState.tsxapps/meteor/client/views/omnichannel/departments/DepartmentsTable/DepartmentItemMenu.tsxapps/meteor/client/views/marketplace/AppsPage/NoMarketplaceOrInstalledAppMatchesEmptyState.tsxapps/meteor/client/views/marketplace/MarketplaceSidebar.tsxapps/meteor/client/views/directory/tabs/users/UsersTab.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppReleases/AppReleasesItem.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesTable.tsxapps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppInstances/AppInstances.tsxapps/meteor/client/views/marketplace/AppsRoute.tsxapps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPage.tsxapps/meteor/client/views/omnichannel/priorities/PriorityList.tsxapps/meteor/client/views/outlookCalendar/OutlookSettingsList/OutlookSettingsList.tsxapps/meteor/client/views/omnichannel/components/AutoCompleteContact/AutoCompleteContact.tsxapps/meteor/client/views/omnichannel/priorities/PrioritiesPage.tsxapps/meteor/client/views/omnichannel/modals/ForwardChatModal.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaEdit.tsxapps/meteor/client/views/omnichannel/slaPolicies/SlaEditWithData.tsxapps/meteor/client/views/omnichannel/modals/EnterpriseDepartmentsModal.tsx
📚 Learning: 2026-02-10T16:32:42.586Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 38528
File: apps/meteor/client/startup/roles.ts:14-14
Timestamp: 2026-02-10T16:32:42.586Z
Learning: In Rocket.Chat's Meteor client code, DDP streams use EJSON and Date fields arrive as Date objects; do not manually construct new Date() in stream handlers (for example, in sdk.stream()). Only REST API responses return plain JSON where dates are strings, so implement explicit conversion there if needed. Apply this guidance to all TypeScript files under apps/meteor/client to ensure consistent date handling in DDP streams and REST responses.
Applied to files:
apps/meteor/client/views/navigation/sidebar/hooks/usePreventDefault.tsapps/meteor/client/views/navigation/sidebar/hooks/useShortcutOpenMenu.tsapps/meteor/client/views/omnichannel/directory/contexts/ChatsContext.ts
📚 Learning: 2026-05-11T20:30:35.265Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 40480
File: apps/meteor/client/meteor/startup/accounts.ts:59-61
Timestamp: 2026-05-11T20:30:35.265Z
Learning: In Rocket.Chat’s Meteor client code, when calling `dispatchToastMessage` with `{ type: 'error' }`, pass the raw caught error object as `message` without manual normalization. `dispatchToastMessage` is designed to accept `message: unknown` for error toasts, so avoid converting errors to strings (e.g., `String(error)`) or extracting `error.message` before passing them.
Applied to files:
apps/meteor/client/views/navigation/sidebar/hooks/usePreventDefault.tsapps/meteor/client/views/navigation/sidebar/hooks/useShortcutOpenMenu.tsapps/meteor/client/views/omnichannel/directory/contexts/ChatsContext.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
apps/meteor/client/views/navigation/sidebar/hooks/usePreventDefault.tsapps/meteor/client/views/navigation/sidebar/hooks/useShortcutOpenMenu.tsapps/meteor/client/views/omnichannel/directory/contexts/ChatsContext.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
apps/meteor/client/views/navigation/sidebar/hooks/usePreventDefault.tsapps/meteor/client/views/navigation/sidebar/hooks/useShortcutOpenMenu.tsapps/meteor/client/views/omnichannel/directory/contexts/ChatsContext.ts
Comment on lines
+6
to
9
| export const useShortcutOpenMenu = (ref: RefObject<Element | null>): void => { | ||
| useEffect(() => { | ||
| const unsubscribe = tinykeys(ref.current as HTMLElement, { | ||
| Alt: (event) => { |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate and display the target file (small, line-bounded)
FILE="apps/meteor/client/views/navigation/sidebar/hooks/useShortcutOpenMenu.ts"
if [ -f "$FILE" ]; then
echo "== $FILE =="
sed -n '1,160p' "$FILE" | cat -n
else
echo "Missing file: $FILE" >&2
exit 1
fi
# Search for tinykeys usage in repo (to see common guarding patterns)
echo
echo "== Search: tinykeys( usage patterns =="
rg -n "tinykeys\(" . | head -n 50
# Search for hook usage (to understand ref type / assignment)
echo
echo "== Search: useShortcutOpenMenu( usage =="
rg -n "useShortcutOpenMenu\(" . | head -n 50Repository: RocketChat/Rocket.Chat
Length of output: 1730
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the call site to see the ref type and what element it points to
sed -n '1,120p' apps/meteor/client/views/navigation/sidebar/RoomList/RoomList.tsx | cat -n
echo
echo "----"
# Inspect the alternate hook implementation (if present)
ALT="apps/meteor/client/sidebar/hooks/useShortcutOpenMenu.ts"
if [ -f "$ALT" ]; then
sed -n '1,140p' "$ALT" | cat -n
else
echo "Missing: $ALT" >&2
fi
echo
echo "----"
# Check if tinykeys target types are present anywhere in repo (sometimes via vendored d.ts)
rg -n "declare function tinykeys|tinykeys\(" apps/meteor -S || trueRepository: RocketChat/Rocket.Chat
Length of output: 4547
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Try to find tinykeys type signatures in-repo (d.ts vendored somewhere)
rg -n "declare\s+(function|const)\s+tinykeys|declare\s+module\s+['\"]tinykeys['\"]|tinykeys\s*:\s*\(" . -S || true
# Also check if tinykeys types are referenced via imports (TS will use node_modules types, but might be vendored)
rg -n "from 'tinykeys'|import\s+tinykeys\s+from\s+'tinykeys'" apps -S
# Inspect the non-v2 sidebar hook (same logic, possibly safer typing/callsites)
sed -n '1,120p' apps/meteor/client/sidebar/hooks/useShortcutOpenMenu.ts | cat -nRepository: RocketChat/Rocket.Chat
Length of output: 1308
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "useShortcutOpenMenu" apps/meteor/client -S | head -n 50
echo
echo "----"
# find imports that reference the non-v2 sidebar hook path
rg -n "from\s+['\"].*sidebar/hooks/useShortcutOpenMenu['\"]" apps/meteor/client -S || trueRepository: RocketChat/Rocket.Chat
Length of output: 795
🏁 Script executed:
#!/bin/bash
set -euo pipefail
sed -n '1,120p' apps/meteor/client/sidebar/RoomList/RoomList.tsx | cat -nRepository: RocketChat/Rocket.Chat
Length of output: 3374
🌐 Web query:
tinykeys API accepts null target throws when target is null
💡 Result:
tinykeys does not explicitly guard against target === null; passing null will fail when it tries to register the event listener (i.e., it calls target.addEventListener(...)), which will throw a runtime error like “Cannot read properties of null (reading 'addEventListener')”. [1] In the current implementation, tinykeys(target, ...) is typed as target: Window | HTMLElement and immediately calls target.addEventListener(event, onKeyEvent, capture), so there’s no code path that handles a null target. [1] Workaround: ensure the value you pass as target is a real Window/HTMLElement (not null) before calling tinykeys, or conditionally delay/skip registration until the element exists.
Citations:
Guard ref.current before calling tinykeys
tinykeys registers the handler by immediately calling target.addEventListener; if ref.current is null, it will throw before unsubscribe is created/cleanup is registered.
Suggested fix
export const useShortcutOpenMenu = (ref: RefObject<Element | null>): void => {
useEffect(() => {
- const unsubscribe = tinykeys(ref.current as HTMLElement, {
+ if (!(ref.current instanceof HTMLElement)) {
+ return;
+ }
+ const unsubscribe = tinykeys(ref.current, {
Alt: (event) => {
if (!(event.target as HTMLElement).className.includes('rcx-sidebar-v2-item')) {
return;
}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/meteor/client/views/navigation/sidebar/hooks/useShortcutOpenMenu.ts`
around lines 6 - 9, The hook useShortcutOpenMenu currently calls
tinykeys(ref.current...) unconditionally which can throw when ref.current is
null; guard by checking that ref.current is non-null before invoking tinykeys
(e.g., if (!ref.current) return/skip), assign the unsubscribe only inside that
guarded branch, and in the useEffect cleanup check/unsubscribe only if
unsubscribe was created (or return a noop) so no attempt is made to call an
undefined unsubscribe; reference useShortcutOpenMenu, ref.current and tinykeys
when locating the call to change.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 121 files
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
As a first step towards upgrading to React 19, it handles types from
@types/reactlooking forward the next major.Issue(s)
Task: ARCH-2170
Steps to test or reproduce
Further comments
No runtime change is expected from it.
Summary by CodeRabbit
Release Notes
ReactNodeinstead ofReactElement)