fix: Non-deterministic comparator in team's channel desertion table#40857
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 0311213 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/jira ARCH-2167 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
WalkthroughReplaces mutating Array.sort with Array.toSorted in ChannelDesertionTable and rewrites the comparator to deterministically handle empty values and compare via localeCompare; adds a changeset declaring a patch for ChangesNon-deterministic Comparator Fix
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
14f7f15 to
97f2051
Compare
97f2051 to
0311213
Compare
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #40857 +/- ##
===========================================
- Coverage 70.12% 70.11% -0.01%
===========================================
Files 3341 3341
Lines 123558 123567 +9
Branches 22136 22078 -58
===========================================
- Hits 86642 86641 -1
- Misses 33567 33576 +9
- Partials 3349 3350 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
It fixes non-deterministic comparator in team's channel desertion table.
Issue(s)
Steps to test or reproduce
Further comments
Suggested by @coderabbitai in #40819
Task: ARCH-2172
Summary by CodeRabbit