Skip to content

feat: Improve manual license management#40916

Draft
dougfabris wants to merge 3 commits into
developfrom
feat/improve-manual-license
Draft

feat: Improve manual license management#40916
dougfabris wants to merge 3 commits into
developfrom
feat/improve-manual-license

Conversation

@dougfabris

@dougfabris dougfabris commented Jun 11, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Depends on: #40858

Issue(s)

Steps to test or reproduce

Further comments

CORE-2104

@dionisio-bot

dionisio-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7920406

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@rocket.chat/core-typings Minor
@rocket.chat/license Minor
@rocket.chat/rest-typings Minor
@rocket.chat/meteor Minor
@rocket.chat/federation-matrix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 8.6.0 milestone Jun 11, 2026
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 27cc4773-4b38-423e-8ea2-76901961cc88

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dougfabris dougfabris force-pushed the feat/improve-manual-license branch from 1acd309 to caf79ce Compare June 11, 2026 21:31
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.13%. Comparing base (64af832) to head (7920406).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #40916      +/-   ##
===========================================
+ Coverage    70.11%   70.13%   +0.01%     
===========================================
  Files         3363     3363              
  Lines       129716   129730      +14     
  Branches     22444    22454      +10     
===========================================
+ Hits         90953    90984      +31     
+ Misses       35445    35429      -16     
+ Partials      3318     3317       -1     
Flag Coverage Δ
unit 70.03% <77.77%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris force-pushed the feat/improve-manual-license branch from caf79ce to 4ca7893 Compare June 17, 2026 12:51
@alfredodelfabro alfredodelfabro modified the milestones: 8.6.0, 8.7.0 Jun 17, 2026
rodrigok and others added 3 commits June 25, 2026 15:07
…ying

Adds a new `POST /api/v1/licenses.validate` REST endpoint that validates a
Rocket.Chat license (V2 or V3 JWT) against the current workspace's validation
structure without applying it, so the result can be previewed from the UI
before the license is committed.

- core-typings: new `LicenseValidationResult` type
- license: `LicenseManager.validateLicenseForPreview()` runs the same
  validation pipeline used on apply (URL, periods, limits) without mutating
  state or emitting events; the shared `licenseValidationBehaviors` constant
  is reused by both the apply and preview paths to avoid duplication
- rest-typings: `isLicensesValidateProps` schema + endpoint typing
- meteor: `licenses.validate` route (edit-privileged-setting)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dougfabris dougfabris force-pushed the feat/improve-manual-license branch from 4ca7893 to 7920406 Compare June 25, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants