Skip to content

fix: Imported fixes 06-24-26#41069

Open
jonasflorencio wants to merge 7 commits into
developfrom
imported-fixes-2026-06-24
Open

fix: Imported fixes 06-24-26#41069
jonasflorencio wants to merge 7 commits into
developfrom
imported-fixes-2026-06-24

Conversation

@jonasflorencio

@jonasflorencio jonasflorencio commented Jun 24, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

All approvals have already been given in the private fork.

Issue(s)

CORE-2268

Steps to test or reproduce

N/A

Further comments

@coderabbitai ignore

@jonasflorencio jonasflorencio requested review from a team as code owners June 24, 2026 17:54
@dionisio-bot

dionisio-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5c0317e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 15 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
Comment thread apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts Outdated
Comment thread packages/models/src/models/SamlUsedAssertions.ts Outdated
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.04%. Comparing base (32880c4) to head (5c0317e).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41069      +/-   ##
===========================================
- Coverage    70.15%   70.04%   -0.12%     
===========================================
  Files         3368     3369       +1     
  Lines       130022   130313     +291     
  Branches     22543    22648     +105     
===========================================
+ Hits         91216    91273      +57     
- Misses       35492    35715     +223     
- Partials      3314     3325      +11     
Flag Coverage Δ
e2e 59.33% <ø> (ø)
e2e-api 47.11% <100.00%> (+0.79%) ⬆️
unit 69.95% <68.42%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-rocketchat julio-rocketchat added this to the 8.7.0 milestone Jun 26, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread packages/models/src/models/SamlUsedAssertions.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants