Skip to content

fix: Missing a visible quote message link #41091

Open
dougfabris wants to merge 1 commit into
developfrom
fix/quote-link-affordance
Open

fix: Missing a visible quote message link #41091
dougfabris wants to merge 1 commit into
developfrom
fix/quote-link-affordance

Conversation

@dougfabris

@dougfabris dougfabris commented Jun 26, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Currently our quote messages doesn't have a visible link, instead the link to jump to the original message is placed in the timestamp which doesn't offer a good affordance for such action. This PR aims to add a clear link for the user to jump to the original message

before

image

after

image

Issue(s)

Closes #31747

Steps to test or reproduce

Further comments

Review in cubic

Task: CORE-2352

@dionisio-bot

dionisio-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a1f86b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 8.7.0 milestone Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dougfabris

Copy link
Copy Markdown
Member Author

/jira CORE

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.87500% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.15%. Comparing base (64af832) to head (a1f86b4).
⚠️ Report is 14 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41091      +/-   ##
===========================================
+ Coverage    70.09%   70.15%   +0.05%     
===========================================
  Files         3363     3370       +7     
  Lines       129716   130046     +330     
  Branches     22444    22561     +117     
===========================================
+ Hits         90925    91234     +309     
- Misses       35479    35498      +19     
- Partials      3312     3314       +2     
Flag Coverage Δ
e2e 59.32% <100.00%> (-0.01%) ⬇️
e2e-api 46.28% <ø> (ø)
unit 70.14% <65.62%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review June 26, 2026 18:55
@dougfabris dougfabris requested a review from a team as a code owner June 26, 2026 18:55

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Quoted message link is wrapped with time text instead of the entire box.

1 participant