Skip to content

Apply PR review feedback: frozen string literals and file handle fix #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OutlawAndy merged 3 commits into from
Mar 11, 2026
Merged

Apply PR review feedback: frozen string literals and file handle fix #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fec8454
Initial plan
Copilot Mar 11, 2026
79d3d4b
Apply PR review feedback: frozen string literals, Rails guard, file h…
Copilot Mar 11, 2026
da3f9fa
Revert Rails engine guard, keep frozen_string_literal in rolemodel-ra…
Copilot Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/generators/rolemodel/base_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'rails/generators/base'
require 'rails/generators/bundle_helper'
require_relative 'replace_content_helper'
Expand Down
2 changes: 2 additions & 0 deletions lib/rolemodel-rails.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module Rolemodel
NODE_VERSION = '24.12.0'
RUBY_VERSION = '4.0.1'
Expand Down
2 changes: 2 additions & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'rails'
require 'bundler/setup'
require 'generator_spec'
Expand Down
3 changes: 1 addition & 2 deletions spec/support/helpers/example_app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ def cleanup_test_app

def clean_test_gemfile
gemfile_path = File.join(destination_root, 'Gemfile')
gemfile = File.open(gemfile_path)

File.write(gemfile_path, gemfile.grep_v(/rolemodel-rails/).join)
File.write(gemfile_path, File.readlines(gemfile_path).grep_v(/rolemodel-rails/).join)
end
end