Skip to content

Remove webdrivers from RSpec generator setup#185

Open
Copilot wants to merge 3 commits intomasterfrom
copilot/remove-webdrivers-from-rspec-setup
Open

Remove webdrivers from RSpec generator setup#185
Copilot wants to merge 3 commits intomasterfrom
copilot/remove-webdrivers-from-rspec-setup

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 26, 2026

Why?

webdrivers manages browser drivers for Selenium-based testing. Since the project uses Playwright (capybara-playwright-driver) for system tests, it's unnecessary and should not be added to generated apps.

What Changed

  • Removed gem 'webdrivers' from the :test gem group in Rolemodel::Testing::RspecGenerator
  • Removed Webdrivers.cache_time = 24.hours.to_i configuration from the capybara_drivers.rb template
  • Bumped version to 0.27.3

Pre-merge checklist

  • Update relevant READMEs
  • Run bin/bump_version or bin/bump_version --patch

Screenshots

N/A


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Remove webdrivers from RSpec setup Remove webdrivers from RSpec generator setup Mar 26, 2026
Copilot AI requested a review from justwiebe March 26, 2026 18:35
@justwiebe
Copy link
Copy Markdown
Contributor

@copilot Remove the spot that sets Webdriver configuration

Copy link
Copy Markdown
Author

Copilot AI commented Mar 26, 2026

@copilot Remove the spot that sets Webdriver configuration

Removed Webdrivers.cache_time = 24.hours.to_i from the capybara_drivers.rb template in 9c2b2d2.

@justwiebe justwiebe marked this pull request as ready for review March 26, 2026 18:57
@justwiebe
Copy link
Copy Markdown
Contributor

@copilot run bin/bump_version and commit the changes

Copy link
Copy Markdown
Author

Copilot AI commented Mar 26, 2026

@copilot run bin/bump_version and commit the changes

Bumped version to 0.27.3 in 31494ff (updated lib/rolemodel_rails/version.rb and Gemfile.lock).

Copilot AI requested a review from justwiebe March 26, 2026 19:01
@OutlawAndy
Copy link
Copy Markdown
Member

@justwiebe would you mind actually dropping the version bump? I'm getting ready to merge the 1.0 update and that will be another conflict.

@justwiebe
Copy link
Copy Markdown
Contributor

@copilot Undo the version bump to help Andy with merge conflicts

@justwiebe justwiebe force-pushed the copilot/remove-webdrivers-from-rspec-setup branch from 9c2b2d2 to 3ca954a Compare March 27, 2026 15:33
@justwiebe
Copy link
Copy Markdown
Contributor

@OutlawAndy Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants