Skip to content

chore: link inline TODO/FIXME to tracking issues #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmetabdullahgultekin merged 1 commit into from
Jun 23, 2026
Merged

chore: link inline TODO/FIXME to tracking issues #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ def get_api_key_config(self) -> dict:
# Audit 2026-04-19 remediation (ML-M1, ML-M5, ML-H4)
# ---------------------------------------------------------------
# ML-M1: SHA256 integrity check for DeepFace Facenet512 weights.
# TODO: populate with known-good hash once the model file is available.
# TODO(#166): populate with known-good hash once the model file is available.
# sha256sum ~/.deepface/weights/facenet512_weights.h5
# When empty string, startup logs a WARNING and skips the check (does not raise).
DEEPFACE_FACENET512_SHA256: str = Field(
Expand Down
2 changes: 1 addition & 1 deletion app/infrastructure/ml/extractors/deepface_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def _verify_model_integrity(model_name: str) -> None:
and the file exists, the digest MUST match or startup is aborted.
* If no pinned hash is configured, the check logs a WARNING and returns
without raising — we do not want to break deploys before the hash
has been recorded. TODO: pin the hash.
has been recorded. TODO(#167): pin the hash.
* If the weight file cannot be located (e.g. custom DEEPFACE_HOME), we
log a warning but do not raise.
"""
Expand Down
Loading